Repository navigation
Allow smaller recoveries after candidate allocation OOM - #16
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A frequently used recovery candidate whose replacement allocation repeatedly returns device-memory OOM can keep being selected ahead of a smaller candidate that would succeed. Defer that failed child for one second while retaining the existing 250 ms device-wide failure backoff. Both selection and direct promotion honor the deadline.
This applies only before sparse binds/accounting changes, after replacement allocation returns VK_ERROR_OUT_OF_DEVICE_MEMORY. Existing ambiguous-failure gates remain intact.
Validation: deterministic size-specific allocator fault injection failed before the fix. Normal and hook-enabled CPU tests now verify unchanged ownership/accounting on failure, exact retry boundaries, and successful smaller-candidate recovery. Production build and 18 CPU/submission tests pass. This is CPU fault-injection evidence, not an observed real-device OOM or game performance claim.