docs: add CLAUDE.md with correct fasten-core paths + fasten-build skill#71
Open
cyberwalk3r wants to merge 3 commits into
Open
docs: add CLAUDE.md with correct fasten-core paths + fasten-build skill#71cyberwalk3r wants to merge 3 commits into
cyberwalk3r wants to merge 3 commits into
Conversation
- the draft file referenced a store-core/ crate that does not exist; the Rust core lives at fasten-core/ (lib name fasten_core) - artifact and header names now match reality: libfasten_core.so and include/fasten_core.h, as CI already uses (fasten-py.yml) - file was previously untracked, so no session on a clean checkout ever saw it Signed-off-by: Himanshu Vimal <himanshu.vimal@gmail.com>
- first project-level skill; points at the CLAUDE.md Commands section rather than duplicating it, per the repo-as-router convention Signed-off-by: Himanshu Vimal <himanshu.vimal@gmail.com>
- src/redact.rs etc were section-relative and ambiguous; now resolvable from the repo root, which also makes them lintable Signed-off-by: Himanshu Vimal <himanshu.vimal@gmail.com>
cyberwalk3r
marked this pull request as ready for review
July 19, 2026 01:07
praveen-garg
approved these changes
Jul 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds the repo-root CLAUDE.md (previously untracked, so no other checkout ever saw it) with correct
fasten-corepaths, plus afasten-buildstarter skill.Why
The draft file referenced a
store-core/crate that does not exist - every build/test command in it failed verbatim. The Rust core lives atfasten-core/(libfasten_core->libfasten_core.so, headerfasten-core/include/fasten_core.h), exactly as CI already uses infasten-py.yml. Agent/editor tooling reads this file as ground truth, so a wrong copy is worse than none.Affected SDK / surface
Tests + verification
test -e: fasten-core/src/redact.rs, catalog.rs, store/{sqlite,postgres}.rs, include/fasten_core.h, bindings/, spec/, tests/).github/workflows/fasten-py.ymlsetsFASTEN_CORE_LIB=.../fasten-core/target/release/libfasten_core.so