Improve assert type specifying extension - #110
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Slevomat sniffs enable checks based on the PHP version phpcs runs on: native mixed type hints and trailing commas in multi-line declarations. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Assert::same(...$args) crashed the analysis with an ArgumentCountError, Assert::null(...$args) specified `$args === null` and thus made all the following code unreachable. Bail out instead of specifying anything when the arguments cannot be resolved positionally. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
PHPStan normalizes named arguments to their positions before invoking the extension, but only when the call is valid - Assert::null(description: $x) used to be read as Assert::null($x) and narrowed the description instead. Also adds test coverage for regular named argument calls. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.