Skip to content

Send every card on a manager's job back to the manager - #5

Merged
neotechnet merged 1 commit into
stack/installed-0.2.7from
fix/card-routing-overlord
Nov 3, 2026
Merged

neotechnet merged 1 commit into
stack/installed-0.2.7from
fix/card-routing-overlord

Conversation

@neotechnet

Copy link
Copy Markdown
Owner

Job dsbot-card-routing-overlord (PLAN-APPROVED, Choice A plus H3). Stacks on stack/installed-0.2.7 (PR #4).

  • refuseCard: the production-label exemption is gone. A deploy card in a manager's job is refused with text that points to the manager: send a DECISION naming the repo and PR, the manager cards Steve and mints the scoped approval, then the Bot runs the bare merge. CARD-IT-YOURSELF opens ordinary cards only, never a production option.
  • show_view: an interactive view in a gated turn is judged like ask_user, including production labels in options, confirm, submit and form parts. Display-only views are unchanged.
  • Logging: every card decided in a Bot Session is logged with allowed, because (not-bot-turn, main-bot, audience-user, card-it-yourself, gated, production-label) and the production label when offered.
  • H3: PLAN-APPROVED and ORDER releases are honoured from a Main Bot or from the admin of a group the receiving Bot is a member of. The log carries authority; a refused sender logs sender-not-manager.

Local gates: build-client --check exit 0; lint 0 errors (40 warnings, same as base); card-gate and view-reply tests 36 of 36; full suite 1666 tests, 1662 pass, 2 skipped, 2 timing flakes (memory.test.js, work-dir.test.js) that pass alone here and on the base.

Steve's rule (2026-11-03): cards on a job a manager dispatched go to that
manager, not to him. The gate still let two kinds through: a card whose
option was the production approval, and interactive show_view cards,
which were never gated. A deploy approval now always goes back to the
manager, CARD-IT-YOURSELF included, and show_view is judged like ask_user.

Every card decided in a Bot Session is logged with the reason that
decided it, so an allowed card can be traced as well as a refused one.

A plan release is now honoured from the admin of a group the receiving
Bot is in, as well as from a Main Bot: SEO Overlord is the manager for
its group but is not a Main Bot, and its releases were logged as
sender-not-main and did nothing.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-03T22:33:07.904726Z 051e199 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 051e199413

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

if (depth > 8 || node === null || typeof node !== 'object') return
if (Array.isArray(node)) { for (const item of node) walk(item, depth + 1); return }
if (node.type === 'options') for (const option of node.options ?? []) labels.push({ label: String(option?.label ?? '') })
if (node.type === 'confirm') labels.push({ label: String(node.confirmLabel ?? '') })

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Include the cancel button when checking production labels

In a delegated turn carrying CARD-IT-YOURSELF, a valid confirm view with confirmLabel: 'Hold' and cancelLabel: 'deploy to production' is allowed because only confirmLabel is inspected. The confirm renderer displays both labels as actionable buttons and includes the selected label in the reply (ds-bot/client.js:6662–6663,7389), so this still opens a production-labeled card in the worker's chat instead of routing it to the manager. Include cancelLabel in the labels passed to judgeCard and cover this case in the tests.

Useful? React with 👍 / 👎.

@neotechnet neotechnet closed this Nov 3, 2026
@neotechnet neotechnet reopened this Nov 3, 2026
@neotechnet
neotechnet merged commit a6fafe8 into stack/installed-0.2.7 Nov 3, 2026
22 of 26 checks passed
@neotechnet
neotechnet deleted the fix/card-routing-overlord branch November 3, 2026 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant