Repository navigation
Send every card on a manager's job back to the manager - #5
Conversation
Steve's rule (2026-11-03): cards on a job a manager dispatched go to that manager, not to him. The gate still let two kinds through: a card whose option was the production approval, and interactive show_view cards, which were never gated. A deploy approval now always goes back to the manager, CARD-IT-YOURSELF included, and show_view is judged like ask_user. Every card decided in a Bot Session is logged with the reason that decided it, so an allowed card can be traced as well as a refused one. A plan release is now honoured from the admin of a group the receiving Bot is in, as well as from a Main Bot: SEO Overlord is the manager for its group but is not a Main Bot, and its releases were logged as sender-not-main and did nothing.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 051e199413
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (depth > 8 || node === null || typeof node !== 'object') return | ||
| if (Array.isArray(node)) { for (const item of node) walk(item, depth + 1); return } | ||
| if (node.type === 'options') for (const option of node.options ?? []) labels.push({ label: String(option?.label ?? '') }) | ||
| if (node.type === 'confirm') labels.push({ label: String(node.confirmLabel ?? '') }) |
There was a problem hiding this comment.
Include the cancel button when checking production labels
In a delegated turn carrying CARD-IT-YOURSELF, a valid confirm view with confirmLabel: 'Hold' and cancelLabel: 'deploy to production' is allowed because only confirmLabel is inspected. The confirm renderer displays both labels as actionable buttons and includes the selected label in the reply (ds-bot/client.js:6662–6663,7389), so this still opens a production-labeled card in the worker's chat instead of routing it to the manager. Include cancelLabel in the labels passed to judgeCard and cover this case in the tests.
Useful? React with 👍 / 👎.
Job dsbot-card-routing-overlord (PLAN-APPROVED, Choice A plus H3). Stacks on stack/installed-0.2.7 (PR #4).
Local gates: build-client --check exit 0; lint 0 errors (40 warnings, same as base); card-gate and view-reply tests 36 of 36; full suite 1666 tests, 1662 pass, 2 skipped, 2 timing flakes (memory.test.js, work-dir.test.js) that pass alone here and on the base.