Skip to content

Keep a question card open through later Bot turns - #23

Merged
neotechnet merged 1 commit into
stack/installed-0.3.5from
fix/cards-survive-bot-turns
Nov 12, 2026
Merged

neotechnet merged 1 commit into
stack/installed-0.3.5from
fix/cards-survive-bot-turns

Conversation

@neotechnet

Copy link
Copy Markdown
Owner

Job HARNESS-CARDS-20261111 / DSB-CARDS-INSTALL-20261112.

Defect 2: an ask_user card closes on any later visible turn

Cause: a local-stack block in src/host/turns.js, carried since the installed ds-bot@0.2.6 patch (7af1306, 2026-11-02) and re-carried onto 0.3.1, 0.3.2 and 0.3.5. It is not in upstream v0.3.1, v0.3.2, v0.3.5, main or dev. At turn/end it deleted the open question when the turn had started with that card open, completed, and was not a hidden Bot-to-Bot turn. So a visible Bot-report turn, or any visible turn that asked nothing, closed Steve's card, with no closed record, and his later click was refused.

Live evidence: Clients Overlord's ask_user at 13:27:34 ET on 11-12 (call toolu_01821Bqw) is gone from state with no answer, after visible report turns 94 to 99. On 11-11, Steve wrote "you keep killing menus or cards before I can answer them" and "once again the card vanishes".

Fix:

  • Drop that turn-end close and the entry.card bookkeeping it alone used.
  • Fix the system prompt sentence that taught Bots the card dies after their next visible turn. It now says the card stays open through the Bot's later turns, including ones that answer other Bots, until the user answers, dismisses or writes, and that a new ask_user replaces it.

The card still closes on an answer, on dismiss, on the user's own message (upstream behaviour), on void_question, and when the Bot asks a new card.

Defect 1: show_view options never render

Not reproduced on the installed 0.3.5, so no change here. Across every Bot's session log since 11-10, the options views that went unanswered (Clients Overlord 11-11 at 13:49, 13:53 and 14:20, Igor 11-10 at 17:10 and 17:11) were all on the old 0.3.2 build. On 0.3.5, ABC Overlord's options views at 14:49 and 14:50 on 11-12 were answered through the card (answer_to_pending_view for that call), and Igor's Telegram view test at 02:28 on 11-12 was answered by a tap.

Tests

  • questions.test.js: the test that asserted the old close is now "a card survives later Bot turns, hidden or visible, until the user writes". It fails on the unpatched turns.js and passes with the fix.
  • questions, view-reply and bot-messages: 64 tests, 62 pass, 2 skipped, 0 fail.
  • Full suite: 2291 tests, 2263 pass, 6 fail, 22 skipped. The 6 are the known env sanitization, connectors-gateway, link.js, phone and queued-deliveries failures, plus the client.js check, which is a local node_modules junction path artifact (nothing under src/client changed).
  • Lint: 0 errors.

Base: stack/installed-0.3.5.

A local-stack block closed the open ask_user card at the end of any visible turn that asked nothing, so a Bot report landing behind the card killed it before the user could tap it, and a late click was refused. The card now waits until the user answers, dismisses or writes, or the Bot asks a new card, and the system prompt no longer teaches Bots the old lifetime.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-12T20:30:53.562429Z 571b2cb PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@neotechnet
neotechnet merged commit 17e84c4 into stack/installed-0.3.5 Nov 12, 2026
14 checks passed
@neotechnet
neotechnet deleted the fix/cards-survive-bot-turns branch November 12, 2026 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant