Repository navigation
Keep a question card open through later Bot turns - #23
Merged
Merged
Conversation
A local-stack block closed the open ask_user card at the end of any visible turn that asked nothing, so a Bot report landing behind the card killed it before the user could tap it, and a late click was refused. The card now waits until the user answers, dismisses or writes, or the Bot asks a new card, and the system prompt no longer teaches Bots the old lifetime.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Job HARNESS-CARDS-20261111 / DSB-CARDS-INSTALL-20261112.
Defect 2: an ask_user card closes on any later visible turn
Cause: a local-stack block in
src/host/turns.js, carried since the installed ds-bot@0.2.6 patch (7af1306, 2026-11-02) and re-carried onto 0.3.1, 0.3.2 and 0.3.5. It is not in upstream v0.3.1, v0.3.2, v0.3.5, main or dev. At turn/end it deleted the open question when the turn had started with that card open, completed, and was not a hidden Bot-to-Bot turn. So a visible Bot-report turn, or any visible turn that asked nothing, closed Steve's card, with no closed record, and his later click was refused.Live evidence: Clients Overlord's ask_user at 13:27:34 ET on 11-12 (call toolu_01821Bqw) is gone from state with no answer, after visible report turns 94 to 99. On 11-11, Steve wrote "you keep killing menus or cards before I can answer them" and "once again the card vanishes".
Fix:
entry.cardbookkeeping it alone used.The card still closes on an answer, on dismiss, on the user's own message (upstream behaviour), on void_question, and when the Bot asks a new card.
Defect 1: show_view options never render
Not reproduced on the installed 0.3.5, so no change here. Across every Bot's session log since 11-10, the options views that went unanswered (Clients Overlord 11-11 at 13:49, 13:53 and 14:20, Igor 11-10 at 17:10 and 17:11) were all on the old 0.3.2 build. On 0.3.5, ABC Overlord's options views at 14:49 and 14:50 on 11-12 were answered through the card (answer_to_pending_view for that call), and Igor's Telegram view test at 02:28 on 11-12 was answered by a tap.
Tests
questions.test.js: the test that asserted the old close is now "a card survives later Bot turns, hidden or visible, until the user writes". It fails on the unpatched turns.js and passes with the fix.Base:
stack/installed-0.3.5.