Skip to content

Drop em dashes from the IM card layer - #22

Merged
neotechnet merged 1 commit into
stack/installed-0.3.5from
fix/im-no-dashes
Nov 12, 2026
Merged

neotechnet merged 1 commit into
stack/installed-0.3.5from
fix/im-no-dashes

Conversation

@neotechnet

Copy link
Copy Markdown
Owner

Job DSB-CARD-DASH-20261112.

The IM card layer joined an option label to its description with an em dash, and several other texts that reach the phone did the same. This replaces every em and en dash in ds-bot/src/host/im with a colon or a plain hyphen-minus. Only punctuation changes.

User-visible text:

  • Option line: 1. Label - description (same form as the view card).
  • Approval body: tool: reason.
  • Settled card: the answer line reads - answer.
  • Connected, secret ask and view notice: a colon, in en, es, fr (Connecté : vous, French spacing) and de.

Comments in format.js, index.js and platforms/*.js follow the same rule.

Tests: no test asserted the old text, so none changed. The IM tests (im, im-format, im-telegram, im-qq, im-weixin) pass 88 of 88. The full suite is 2291 tests: 2262 pass, 7 fail, 22 skipped. The 7 are the known env sanitization, connectors-gateway, link.js, phone and queued-deliveries failures, the client.js check (a local node_modules junction path artifact, nothing under src/client changed), and one rounds.test.js flake that passed 3 of 3 alone. Lint: 0 errors.

Base: stack/installed-0.3.5.

The option line, the approval body, the settled card and the connected, secret and view notices joined their parts with an em dash, which reached the phone. Each one is now a colon or a plain hyphen, in all four locales, and the comments in src/host/im follow the same rule. Only punctuation changes.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-12T18:11:59.078187Z 06f00e1 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@neotechnet
neotechnet merged commit adfe5ce into stack/installed-0.3.5 Nov 12, 2026
14 checks passed
@neotechnet
neotechnet deleted the fix/im-no-dashes branch November 12, 2026 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant