Skip to content

Keep the operator's ask on its Operator Task card - #15

Merged
neotechnet merged 2 commits into
stack/installed-0.2.7from
feat/optasks-keep-ask-20261106
Nov 6, 2026
Merged

neotechnet merged 2 commits into
stack/installed-0.2.7from
feat/optasks-keep-ask-20261106

Conversation

@neotechnet

@neotechnet neotechnet commented Nov 6, 2026 •

Copy link
Copy Markdown
Owner

Issue

Reported by the operator (Steve, 2026-11-06 08:24 ET) with a screenshot. No GitHub issue was opened.

The Operator Tasks card titled "Your ask" showed the Bot's running tool step as the ask, so a real task read "Running read on design_fidelity.py" and the operator's own request was lost.

What changed / 改了什么

Six files, and nothing outside them: the operator task view on the host and in the browser, the work record, one i18n key, its tests, and the rebuilt client.js.

  • src/client/operator-tasks.js: the ask card shows the first line of the operator's message, trimmed, and the running step below it as a small note. The step can move on; the ask stays what it was. An ask that was never recorded reads "The ask is not recorded" instead of showing a step.
  • src/host/operator-tasks.js: the ask sent to the panel is the first line of the operator's text, never the Bot's own words for a step; a work record's ask wins over the hand-on message; the relay header line is not part of the ask.
  • src/host/handoffs.js: a job handed to another Bot keeps the operator's ask on its work record, so the Bot that takes it on still shows the request after the turn that took it has ended.
  • src/client/i18n.js: one new key, "The ask is not recorded", with its Chinese text.
  • client.js rebuilt and committed.

src/host/turns.js is untouched: the running turn already carries the ask on the work view, so this fix needs no change there.

Changelog

The Operator Tasks card keeps what you asked for, and shows what the Bot is doing below it instead of in place of it.

How I checked it / 怎么验证的

  • npm test (in ds-bot/) - 1699 tests, 1697 pass, 0 fail, 2 skipped
  • node scripts/build-client.mjs --check - exit 0
  • npm run lint - 0 errors, 40 pre-existing warnings
  • Smoke test, for changes to index.js or src/host/ - not run locally: the bench needs a DeepSeek Harness checkout beside the repo and a POSIX shell, and this session is on Windows. CI runs the desktop profile and Docker startup checks on this branch. The visible acceptance proof is the installed-build capture taken after the profile install (this is the dsh-optasks patch job).
  • Screenshot attached, for interface changes - comes with the installed build; the running app still carries the old bundle until the profile patch is installed.

Unit tests added in test/operator-tasks.test.js: a running step sits below the ask and never replaces it; an ask that was not recorded says so with the step as its note; a handed-on job keeps the operator ask on its work record and the turn taking it shows that ask; the relay header line is not part of the ask; the ask is the first line and the Bot's own words never stand in for it.

Checklist / 检查

  • One issue, one subject. / 只做一件事。
  • src/client/ changed → npm run build ran and client.js is committed. / 改了 src/client/ 就已重新 build 并提交 client.js。
  • No keys, tokens or personal data, also in screenshots. / 没有密钥、token 或个人信息,截图里也没有。
  • No AI tool as author or Co-authored-by. / 没有把 AI 工具写成作者或 Co-authored-by。

The card showed the Bot's running tool step in place of the ask, so a task
read "Running read on design_fidelity.py" and the request was lost. The card
now keeps the first line of the operator's message and shows the live step
below it as a note. A job handed to another Bot keeps the ask on its work
record so the Bot that picks it up still shows it, and a card whose ask was
not recorded says so instead of showing a step.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-06T14:24:33.995996Z 1db74d1 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1db74d10ed

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread ds-bot/src/host/turns.js Outdated
entry.originAt ??= Date.now()
delete entry.originFrom
const asked = textOf(event.data.content)
const asked = textOf(event.data.content).replace(/^\[(?:[^\r\n]*\]\r?\n|[^\]\r?\n]*\])/, '')

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve bracketed text in direct operator messages

For a direct user message beginning with square brackets, this removes the user's own text even though there is no relay header to strip. For example, [Fix the sidebar] becomes empty and the card displays “The ask is not recorded”; [Fix the sidebar]\nKeep the step below it instead displays the second line as the ask. The altered text also propagates into newly opened work records. Preserve direct user content and restrict header removal to messages known to contain generated headers; the SOURCE_KIND relay path already strips its header separately.

Useful? React with 👍 / 👎.

The plan declared src/host/turns.js out of scope, and the fix does not need it:
the running turn already carries the ask on the work view, and the work record
is saved by handoffs.js. The relay header strip and the work record lookup move
to the operator task view, so the branch touches only the operator task files.
@neotechnet
neotechnet merged commit dcfd997 into stack/installed-0.2.7 Nov 6, 2026
13 checks passed
@neotechnet
neotechnet deleted the feat/optasks-keep-ask-20261106 branch November 6, 2026 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant