Redirect existing Parameters (and merge with set parameters)

[paavo]

I'd love to have a way to merge existing Parameters with additional Params set by the redirect target.
Not sure if this is a Bug or Feature-Request @Sebobo 😆
I guess it's easiest to explain this with an example:

The existing redirect:

What happens:
Source /pronunciation?utm_source=Print
Redirects to: /pronunciation-1?acceptAllCookies

What should happen:
Source /pronunciation?utm_source=Print
Redirects to: /pronunciation-1?acceptAllCookies&utm_source=Print

---

Redirects without a target Parameter transfer parameters:
Source /data-protection?yolo=true
Redirects to: /privacy-notice?yolo=true

[dos-format-d]

Maybe a bit late, but i have found a way on how we could implement such functionality @Sebobo :
My First thought was to add an eel Evaluation for query params so that we could do something like this:

Redirect:
  sourcePath: 'foo'
  targetUri: '/bar?xyz=${test}'

so that when eelEvaluating the 'bar?xyz=${test}' string with the queryParams from the request e.g: /foo?test=foobar i would be redirected to '/bar?xyz=foobar'
But this turned out to be a bit of a challenge since the eelEvaluator is not able to evaluate this string.
A workaround would be:

Redirect:
  sourcePath: 'foo'
  targetUri: `'/bar?${'xyz=' + test}'`

But this looks bad, will break all redirects which have any query params set and is not very intuitive in my opinion.

So i came up with another idea:
We can write a new function which replaces those ${...} placeholders via regex and insert the value of the queryParams that come from the incoming request foo?test=foobar

What do you think about this?

[Sebobo]

I think this should be rather easy to solve for your use cases in this line by merging the two query parameter lists

redirecthandler/Classes/RedirectService.php

Line 113 in af27046

if (isset($targetUriParts['query'])) {

.

But other people might not want that, so this would require a feature flag.