Skip to content

BUGFIX: Fix nested array exception when encountering for loops #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dlubitz merged 3 commits into from
Jun 4, 2026
Merged

BUGFIX: Fix nested array exception when encountering for loops #154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5a33c6f
TEST: Add failing for-loop tests
benno5020 May 29, 2026
0dca4ec
TEST: Add failing tests for for loop's init and loop expressions
benno5020 Jun 3, 2026
67f9099
BUGFIX: Fix nested arrays error when encountering for loops
benno5020 Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions src/ContentRepository90/Rules/ContentDimensionCombinatorGetAllAllowedCombinationsRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,15 +75,7 @@ public function leaveNode(Node $node)
}
});

if (in_array('expr', $node->getSubNodeNames())) {
/** @var Node\Expr $newExpr */
$newExpr = $traverser->traverse([$node->expr])[0];
$node->expr = $newExpr;
} elseif (in_array('cond', $node->getSubNodeNames())) {
/** @var Node\Expr $newCond */
$newCond = $traverser->traverse([$node->cond])[0];
$node->cond = $newCond;
} else {
if (!self::traverseStatementExpressions($traverser, $node)) {
return null;
}

Expand Down
10 changes: 1 addition & 9 deletions src/ContentRepository90/Rules/ContextGetRootNodeRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,15 +80,7 @@ public function leaveNode(Node $node)
}
});

if (in_array('expr', $node->getSubNodeNames())) {
/** @var Node\Expr $newExpr */
$newExpr = $traverser->traverse([$node->expr])[0];
$node->expr = $newExpr;
} elseif (in_array('cond', $node->getSubNodeNames())) {
/** @var Node\Expr $newCond */
$newCond = $traverser->traverse([$node->cond])[0];
$node->cond = $newCond;
} else {
if (!self::traverseStatementExpressions($traverser, $node)) {
return null;
}

Expand Down
10 changes: 1 addition & 9 deletions src/ContentRepository90/Rules/NodeFindParentNodeRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,15 +74,7 @@ public function leaveNode(Node $node)
}
});

if (in_array('expr', $node->getSubNodeNames())) {
/** @var Node\Expr $newExpr */
$newExpr = $traverser->traverse([$node->expr])[0];
$node->expr = $newExpr;
} elseif (in_array('cond', $node->getSubNodeNames())) {
/** @var Node\Expr $newCond */
$newCond = $traverser->traverse([$node->cond])[0];
$node->cond = $newCond;
} else {
if (!self::traverseStatementExpressions($traverser, $node)) {
return null;
}

Expand Down
10 changes: 1 addition & 9 deletions src/ContentRepository90/Rules/NodeGetChildNodesRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,15 +100,7 @@ public function leaveNode(Node $node)
}
});

if (in_array('expr', $node->getSubNodeNames())) {
/** @var Node\Expr $newExpr */
$newExpr = $traverser->traverse([$node->expr])[0];
$node->expr = $newExpr;
} elseif (in_array('cond', $node->getSubNodeNames())) {
/** @var Node\Expr $newCond */
$newCond = $traverser->traverse([$node->cond])[0];
$node->cond = $newCond;
} else {
if (!self::traverseStatementExpressions($traverser, $node)) {
return null;
}

Expand Down
10 changes: 1 addition & 9 deletions src/ContentRepository90/Rules/NodeGetContextGetWorkspaceRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,15 +80,7 @@ public function leaveNode(Node $node)
}
});

if (in_array('expr', $node->getSubNodeNames())) {
/** @var Node\Expr $newExpr */
$newExpr = $traverser->traverse([$node->expr])[0];
$node->expr = $newExpr;
} elseif (in_array('cond', $node->getSubNodeNames())) {
/** @var Node\Expr $newCond */
$newCond = $traverser->traverse([$node->cond])[0];
$node->cond = $newCond;
} else {
if (!self::traverseStatementExpressions($traverser, $node)) {
return null;
}

Expand Down
10 changes: 1 addition & 9 deletions src/ContentRepository90/Rules/NodeGetDepthRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,15 +74,7 @@ public function leaveNode(Node $node)
}
});

if (in_array('expr', $node->getSubNodeNames())) {
/** @var Node\Expr $newExpr */
$newExpr = $traverser->traverse([$node->expr])[0];
$node->expr = $newExpr;
} elseif (in_array('cond', $node->getSubNodeNames())) {
/** @var Node\Expr $newCond */
$newCond = $traverser->traverse([$node->cond])[0];
$node->cond = $newCond;
} else {
if (!self::traverseStatementExpressions($traverser, $node)) {
return null;
}

Expand Down
10 changes: 1 addition & 9 deletions src/ContentRepository90/Rules/NodeGetDimensionsRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,15 +74,7 @@ public function leaveNode(Node $node)
}
});

if (in_array('expr', $node->getSubNodeNames())) {
/** @var Node\Expr $newExpr */
$newExpr = $traverser->traverse([$node->expr])[0];
$node->expr = $newExpr;
} elseif (in_array('cond', $node->getSubNodeNames())) {
/** @var Node\Expr $newCond */
$newCond = $traverser->traverse([$node->cond])[0];
$node->cond = $newCond;
} else {
if (!self::traverseStatementExpressions($traverser, $node)) {
return null;
}

Expand Down
10 changes: 1 addition & 9 deletions src/ContentRepository90/Rules/NodeGetHiddenBeforeAfterDateTimeRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,15 +85,7 @@ public function leaveNode(Node $node)
}
});

if (in_array('expr', $node->getSubNodeNames())) {
/** @var Node\Expr $newExpr */
$newExpr = $traverser->traverse([$node->expr])[0];
$node->expr = $newExpr;
} elseif (in_array('cond', $node->getSubNodeNames())) {
/** @var Node\Expr $newCond */
$newCond = $traverser->traverse([$node->cond])[0];
$node->cond = $newCond;
} else {
if (!self::traverseStatementExpressions($traverser, $node)) {
return null;
}

Expand Down
10 changes: 1 addition & 9 deletions src/ContentRepository90/Rules/NodeGetIdentifierRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,15 +75,7 @@ public function leaveNode(Node $node)
}
});

if (in_array('expr', $node->getSubNodeNames())) {
/** @var Node\Expr $newExpr */
$newExpr = $traverser->traverse([$node->expr])[0];
$node->expr = $newExpr;
} elseif (in_array('cond', $node->getSubNodeNames())) {
/** @var Node\Expr $newCond */
$newCond = $traverser->traverse([$node->cond])[0];
$node->cond = $newCond;
} else {
if (!self::traverseStatementExpressions($traverser, $node)) {
return null;
}

Expand Down
10 changes: 1 addition & 9 deletions src/ContentRepository90/Rules/NodeGetNodeTypeGetNameRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,15 +83,7 @@ public function leaveNode(Node $node)
}
);

if (in_array('expr', $node->getSubNodeNames())) {
/** @var Node\Expr $newExpr */
$newExpr = $traverser->traverse([$node->expr])[0];
$node->expr = $newExpr;
} elseif (in_array('cond', $node->getSubNodeNames())) {
/** @var Node\Expr $newCond */
$newCond = $traverser->traverse([$node->cond])[0];
$node->cond = $newCond;
} else {
if (!self::traverseStatementExpressions($traverser, $node)) {
return null;
}

Expand Down
10 changes: 1 addition & 9 deletions src/ContentRepository90/Rules/NodeGetNodeTypeRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,15 +79,7 @@ public function leaveNode(Node $node)
}
});

if (in_array('expr', $node->getSubNodeNames())) {
/** @var Node\Expr $newExpr */
$newExpr = $traverser->traverse([$node->expr])[0];
$node->expr = $newExpr;
} elseif (in_array('cond', $node->getSubNodeNames())) {
/** @var Node\Expr $newCond */
$newCond = $traverser->traverse([$node->cond])[0];
$node->cond = $newCond;
} else {
if (!self::traverseStatementExpressions($traverser, $node)) {
return null;
}

Expand Down
10 changes: 1 addition & 9 deletions src/ContentRepository90/Rules/NodeGetParentRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,15 +75,7 @@ public function leaveNode(Node $node)
}
});

if (in_array('expr', $node->getSubNodeNames())) {
/** @var Node\Expr $newExpr */
$newExpr = $traverser->traverse([$node->expr])[0];
$node->expr = $newExpr;
} elseif (in_array('cond', $node->getSubNodeNames())) {
/** @var Node\Expr $newCond */
$newCond = $traverser->traverse([$node->cond])[0];
$node->cond = $newCond;
} else {
if (!self::traverseStatementExpressions($traverser, $node)) {
return null;
}

Expand Down
10 changes: 1 addition & 9 deletions src/ContentRepository90/Rules/NodeGetPathRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,15 +80,7 @@ public function leaveNode(Node $node)
}
});

if (in_array('expr', $node->getSubNodeNames())) {
/** @var Node\Expr $newExpr */
$newExpr = $traverser->traverse([$node->expr])[0];
$node->expr = $newExpr;
} elseif (in_array('cond', $node->getSubNodeNames())) {
/** @var Node\Expr $newCond */
$newCond = $traverser->traverse([$node->cond])[0];
$node->cond = $newCond;
} else {
if (!self::traverseStatementExpressions($traverser, $node)) {
return null;
}

Expand Down
10 changes: 1 addition & 9 deletions src/ContentRepository90/Rules/NodeSearchServiceRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,15 +117,7 @@ public function leaveNode(Node $node)
}
});

if (in_array('expr', $node->getSubNodeNames())) {
/** @var Node\Expr $newExpr */
$newExpr = $traverser->traverse([$node->expr])[0];
$node->expr = $newExpr;
} elseif (in_array('cond', $node->getSubNodeNames())) {
/** @var Node\Expr $newCond */
$newCond = $traverser->traverse([$node->cond])[0];
$node->cond = $newCond;
} else {
if (!self::traverseStatementExpressions($traverser, $node)) {
return null;
}

Expand Down
10 changes: 1 addition & 9 deletions src/ContentRepository90/Rules/NodeTypeAllowsGrandchildNodeTypeRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,15 +95,7 @@ public function leaveNode(Node $node)
}
});

if (in_array('expr', $node->getSubNodeNames())) {
/** @var Node\Expr $newExpr */
$newExpr = $traverser->traverse([$node->expr])[0];
$node->expr = $newExpr;
} elseif (in_array('cond', $node->getSubNodeNames())) {
/** @var Node\Expr $newCond */
$newCond = $traverser->traverse([$node->cond])[0];
$node->cond = $newCond;
} else {
if (!self::traverseStatementExpressions($traverser, $node)) {
return null;
}

Expand Down
10 changes: 1 addition & 9 deletions src/ContentRepository90/Rules/NodeTypeGetAutoCreatedChildNodesRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,15 +77,7 @@ public function leaveNode(Node $node)
}
});

if (in_array('expr', $node->getSubNodeNames())) {
/** @var Node\Expr $newExpr */
$newExpr = $traverser->traverse([$node->expr])[0];
$node->expr = $newExpr;
} elseif (in_array('cond', $node->getSubNodeNames())) {
/** @var Node\Expr $newCond */
$newCond = $traverser->traverse([$node->cond])[0];
$node->cond = $newCond;
} else {
if (!self::traverseStatementExpressions($traverser, $node)) {
return null;
}

Expand Down
12 changes: 1 addition & 11 deletions src/ContentRepository90/Rules/NodeTypeGetTypeOfAutoCreatedChildNodeRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,24 +86,14 @@ public function leaveNode(Node $node)
}
});

if (in_array('expr', $node->getSubNodeNames())) {
/** @var Node\Expr $newExpr */
$newExpr = $traverser->traverse([$node->expr])[0];
$node->expr = $newExpr;
} elseif (in_array('cond', $node->getSubNodeNames())) {
/** @var Node\Expr $newCond */
$newCond = $traverser->traverse([$node->cond])[0];
$node->cond = $newCond;
} else {
if (!self::traverseStatementExpressions($traverser, $node)) {
return null;
}

if (!$visitor->changed) {
return null;
}

$node->expr = $newExpr;

return [
new Nop(), // Needed, to render the comment below
self::withTodoComment(
Expand Down
10 changes: 1 addition & 9 deletions src/ContentRepository90/Rules/NodeTypeManagerAccessRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,15 +71,7 @@ public function leaveNode(Node $node)
}
});

if (in_array('expr', $node->getSubNodeNames())) {
/** @var Node\Expr $newExpr */
$newExpr = $traverser->traverse([$node->expr])[0];
$node->expr = $newExpr;
} elseif (in_array('cond', $node->getSubNodeNames())) {
/** @var Node\Expr $newCond */
$newCond = $traverser->traverse([$node->cond])[0];
$node->cond = $newCond;
} else {
if (!self::traverseStatementExpressions($traverser, $node)) {
return null;
}

Expand Down
10 changes: 1 addition & 9 deletions src/ContentRepository90/Rules/WorkspaceGetBaseWorkspaceRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,15 +80,7 @@ public function leaveNode(Node $node)
}
});

if (in_array('expr', $node->getSubNodeNames())) {
/** @var Node\Expr $newExpr */
$newExpr = $traverser->traverse([$node->expr])[0];
$node->expr = $newExpr;
} elseif (in_array('cond', $node->getSubNodeNames())) {
/** @var Node\Expr $newCond */
$newCond = $traverser->traverse([$node->cond])[0];
$node->cond = $newCond;
} else {
if (!self::traverseStatementExpressions($traverser, $node)) {
return null;
}

Expand Down
10 changes: 1 addition & 9 deletions src/ContentRepository90/Rules/WorkspaceGetBaseWorkspacesRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,15 +84,7 @@ public function leaveNode(Node $node)
}
});

if (in_array('expr', $node->getSubNodeNames())) {
/** @var Node\Expr $newExpr */
$newExpr = $traverser->traverse([$node->expr])[0];
$node->expr = $newExpr;
} elseif (in_array('cond', $node->getSubNodeNames())) {
/** @var Node\Expr $newCond */
$newCond = $traverser->traverse([$node->cond])[0];
$node->cond = $newCond;
} else {
if (!self::traverseStatementExpressions($traverser, $node)) {
return null;
}

Expand Down
10 changes: 1 addition & 9 deletions src/ContentRepository90/Rules/WorkspaceGetDescriptionRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,15 +82,7 @@ public function leaveNode(Node $node)
}
});

if (in_array('expr', $node->getSubNodeNames())) {
/** @var Node\Expr $newExpr */
$newExpr = $traverser->traverse([$node->expr])[0];
$node->expr = $newExpr;
} elseif (in_array('cond', $node->getSubNodeNames())) {
/** @var Node\Expr $newCond */
$newCond = $traverser->traverse([$node->cond])[0];
$node->cond = $newCond;
} else {
if (!self::traverseStatementExpressions($traverser, $node)) {
return null;
}

Expand Down
10 changes: 1 addition & 9 deletions src/ContentRepository90/Rules/WorkspaceGetNameRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,15 +75,7 @@ public function leaveNode(Node $node)
}
});

if (in_array('expr', $node->getSubNodeNames())) {
/** @var Node\Expr $newExpr */
$newExpr = $traverser->traverse([$node->expr])[0];
$node->expr = $newExpr;
} elseif (in_array('cond', $node->getSubNodeNames())) {
/** @var Node\Expr $newCond */
$newCond = $traverser->traverse([$node->cond])[0];
$node->cond = $newCond;
} else {
if (!self::traverseStatementExpressions($traverser, $node)) {
return null;
}

Expand Down
10 changes: 1 addition & 9 deletions src/ContentRepository90/Rules/WorkspaceGetTitleRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,15 +82,7 @@ public function leaveNode(Node $node)
}
});

if (in_array('expr', $node->getSubNodeNames())) {
/** @var Node\Expr $newExpr */
$newExpr = $traverser->traverse([$node->expr])[0];
$node->expr = $newExpr;
} elseif (in_array('cond', $node->getSubNodeNames())) {
/** @var Node\Expr $newCond */
$newCond = $traverser->traverse([$node->cond])[0];
$node->cond = $newCond;
} else {
if (!self::traverseStatementExpressions($traverser, $node)) {
return null;
}

Expand Down
Loading