TASK: Replace removed and deprecated PhpUnit mock APIs in test - #4176
Merged
Merged
Conversation
getMockForAbstractClass() is removed in PHPUnit 12 without replacement; for a plain interface createMock() is the direct equivalent. The same file still used MockBuilder::setMethods(), which was already removed in PHPUnit 10 - it stayed unnoticed because every test in this class is skipped. Renamed to onlyMethods() so the file does not fatal the day these tests are revived.
mhsdesign
approved these changes
Aug 25, 2026
Member
|
We are targeting with this batch of changes 9.2 deliberately right because we want to make it PHPUnit 12 compatible ... or Neos 9.3 but definitely not Neos 9.1 or 9.0 right? Makes fully sense, can be merged directly if you like one approval for this minor change is enough for this in Ui land;) |
Member
Author
Exactly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getMockForAbstractClass() is removed in PHPUnit 12 without replacement; for a plain interface createMock() is the direct equivalent.
The same file still used MockBuilder::setMethods(), which was already removed in PHPUnit 10 - it stayed unnoticed because every test in this class is skipped. Renamed to onlyMethods() so the file does not fatal the day these tests are revived.