Conversation
Member
Author
|
This change was initially not so complex, but after some scrolling chrome lost the connection between the visual and the interactive position of the toolbar and the interaction became madness. This is why the position in the sticky case is now calculated via JS instead of CSS. Maybe the browsers fix this until we release 9.3 and we could simplify it again? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Let the CKEditor toolbar become sticky in long editables when scrolling, similar to the NodeToolbar.
This change was made with some agentic help as the positioning is quite complex and has many edge cases.
How I did it
Todos:
How to verify it
CleanShot.2026-07-14.at.22.31.32.mp4