Bugfix: add ability for view only users to interact with preview page and view data in inspector - #4152
Open
t-heuser wants to merge 1 commit into
Conversation
… and view node data in inspector
Member
|
Hi thanks ill need to find some time to retest this. It seems everything is in one commit so i cannot judge by reading whats new ... but maybe thats not a problem:) |
Author
|
@mhsdesign Almost everything in the JS files changed, the PHP part stayed the same :) |
Author
|
@mhsdesign Any updates? :) |
Member
|
Nope im still occupied with the 9.2 release. But i wonder, the original pr from robert did not look that bad and i did understood it last time i reviewed ^^ i dont understand the transition from his javascript code changes to this fully new approach - im missing that diff^^ - why this is the successor. Here are also some oddities we have never used before like |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the successor of #3921. It contains the bugfix and implements all remarks from the comments of the original PR.
What I did
Previous Behaviour:
Fixed Behaviour:
How I did it
How to verify it
BEFORE


AFTER