Skip to content

FEATURE: Mark inherited disabled nodes in document and content tree - #3902

Open
dlubitz wants to merge 1 commit into
neos:9.2from
dlubitz:90/feature/inherited-disabled-nodes
Open

dlubitz wants to merge 1 commit into
neos:9.2from
dlubitz:90/feature/inherited-disabled-nodes

Conversation

@dlubitz

@dlubitz dlubitz commented Dec 11, 2024 •

Copy link
Copy Markdown
Contributor

Fixes #3896

This marks nodes, which are disabled by inheritence, because a ancestor node is disabled, with a dedicated icon.

image

@dlubitz dlubitz added Feature Label to mark the change as feature 9.0 labels Dec 11, 2024
@dlubitz dlubitz self-assigned this Dec 11, 2024
@Sebobo
Sebobo requested review from Sebobo and mhsdesign December 12, 2024 08:31
Comment on lines 105 to 108
'_hidden' => $node->tags->withoutInherited()->contain(SubtreeTag::disabled()),
'_hiddenByAncestors' => $node->tags->onlyInherited()->contain(SubtreeTag::disabled()),
'_hiddenInIndex' => $node->getProperty('hiddenInMenu'),
'_hasTimeableNodeVisibility' =>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all this stuff is slightly getting more and more bloated ... i dont like that :D maybe we should do something similar to what we have done with other data: use bit masks ... this is especially useful to denote that there is likely of all the things only one state that we really want to highlight in the ui.

export enum TypeOfChange {
NODE_HAS_BEEN_CREATED = 0b0001,
NODE_HAS_BEEN_CHANGED = 0b0010,
NODE_HAS_BEEN_MOVED = 0b0100,
NODE_HAS_BEEN_DELETED = 0b1000
}

aside from this the chnage looks good :D Code wise it looks fine and should work ... is there anything missing than to disucss if we like to keep introducing data bloat :D ?

@dlubitz
dlubitz force-pushed the 90/feature/inherited-disabled-nodes branch 3 times, most recently from 37f9c64 to ed4e96c Compare July 13, 2026 07:03
@dlubitz
dlubitz changed the base branch from 9.0 to 9.2 July 13, 2026 08:33
@dlubitz
dlubitz force-pushed the 90/feature/inherited-disabled-nodes branch from ed4e96c to 13e3376 Compare July 13, 2026 08:34
@github-actions github-actions Bot added 9.2 and removed 9.0 labels Jul 13, 2026
@dlubitz
dlubitz force-pushed the 90/feature/inherited-disabled-nodes branch from 13e3376 to 0536eb9 Compare July 13, 2026 08:39
@dlubitz
dlubitz marked this pull request as ready for review July 13, 2026 08:47
@dlubitz

dlubitz commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

I've rebased this on 9.2 so we can have it there as a feature.

@mhsdesign mhsdesign left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, i see you have also created #4161 but this feature pr is not feature complete without would behave buggy - e.g not update? We cannot have one without the other ...

but speaking about the other ... the change introduces more complexity to our already hopeless tree.

I am restricting myself to adding more features to the tree - for example i wanted to show deleted nodes to allow their publication - and rather started to work on incorporating a new foundation for our tree which is fully server/php backed and should also be fast.

#3944

The problem is that it was not a super big priority so far. Our current tree is already not maintainable and fully undertested by E2E tests.

I think as developers we cannot add more and more things this broken tree but must refactor first and consider there the features we would like for a version 2 like showing and updating inherited nodes as well as showing deleted nodes as well as a possible way to paginate.

@mhsdesign

Copy link
Copy Markdown
Member

An alternative we could consider is to still have this feature on our current tree implementation but add e2e tests for all scenarios and then later switch out the implementation ... but that still makes our current tree more complex which it can barely handle

@dlubitz

dlubitz commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

I see your point, but stopping developing at all is also not an option for me. IF there were already hard progress on rewriting thing, ok. But nobody seems to work active on this.

This PR here works stand alone for the current node. BUT the child nodes are not updated immediatelly. Only a manual reload of the trees/full UI shows the hidden children. And yes, this was basically the idea of this change.

@Sebobo Sebobo added 9.3 and removed 9.2 labels Sep 22, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

9.3 Feature Label to mark the change as feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FEATURE: Mark inherited disabled nodes in tree

3 participants