TASK: Update to PHPUnit 11 - #183
Merged
Merged
Conversation
PhpUnit 11 deprecated metadata in doc comments, so `@test`, `@dataProvider` and `@group large` are replaced by the `#[Test]`, `#[DataProvider]` and `#[Large]` attributes across all tests.
PhpUnit 10 deprecated and PhpUnit 11 no longer supports non-static data providers, they are called without instantiating the test case.
Replace inline fully qualified and namespace-prefixed class references with `use` imports in test classes.
Update the test suites to the mocking API supported by PHPUnit 11: * `->will(self::returnValue(…))` becomes `->willReturn(…)`, the same for `returnCallback`, `returnSelf` and `throwException` * `setMethods()` becomes `onlyMethods()` * `withConsecutive()` is gone, so those expectations are rewritten using an invocation matcher and `willReturnCallback()` that checks `numberOfInvocations()` No test behaviour is changed.
Flow 8.0 through 8.3 ship older PhpUnit versions, so the test suite that was updated for PhpUnit 11 can no longer run against them. Drop those branches from the requirement and the CI test matrix. Also update the checkout action to v6.
Member
Author
|
With e79fdfb this needs a minor release. |
Member
Author
|
It fails for Flow 9, as that still requires PhpUnit 9… |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.