Skip to content

BUGFIX: Prevent infinite recursion in form element node label #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
signalwerk wants to merge 1 commit into
base: main
Choose a base branch
from
Open

BUGFIX: Prevent infinite recursion in form element node label #160

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Configuration/NodeTypes.FormElement.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,11 @@
constraints:
nodeTypes:
'*': false
label: "${node.properties.identifier || node.properties.label || ((Neos.Node.label(node) || node.nodeTypeName) + ' (' + node.name + ')')}"
# Note: this must not fall back to Neos.Node.label(node) - that delegates to
# DelegatingNodeLabelRenderer, which evaluates this very expression again and
# thus recurses infinitely. The fallback below mirrors the label the core
# renders for node types without a label expression.
label: "${node.properties.identifier || node.properties.label || (node.nodeTypeName.value + (node.name ? ' (' + node.name.value + ')' : ''))}"
ui:
inlineEditable: true
label: 'Form Element'
Expand Down