Stabilize portals regression test against synchronize_seqscans (v15)#929
Open
bayandin wants to merge 1 commit intoREL_15_STABLE_neonfrom
Open
Stabilize portals regression test against synchronize_seqscans (v15)#929bayandin wants to merge 1 commit intoREL_15_STABLE_neonfrom
bayandin wants to merge 1 commit intoREL_15_STABLE_neonfrom
Conversation
bayandin
force-pushed
the
bayandin/fix-portals-seqscan-flake-v15
branch
from
ee1a5f8 to
aec5f4f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
portalspg_regress test declares cursors ontenk2withoutORDER BY, relying on heap scan order for expected output. Whensynchronize_seqscansis on (the default) and another backend in the same parallel group is concurrently scanningtenk2, the new scan can start mid-table, producing rows in a different order than the.outfile expects.The issue surfaces more on slower storages (for example network-attached), where scan timing differences widen the window for concurrent scan synchronization.
Summary of changes
SET synchronize_seqscans = off;at the top ofportals.sqlandRESET synchronize_seqscans;at the end