docs(plan): Wave N gap-bridge audit — planning review fixes - #122
Merged
Conversation
Adds the Wave N planning artifacts (slices 55–57, audit report) and applies all fixes identified by nw-documentarist-reviewer and nw-acceptance-designer-reviewer in the post-planning review session. Key changes: - slice-55: lock disclaimer placement to adjacent-copy; inline D3/D4/D8 verbatim placeholder text with grep-able pending-review markers - slice-56: rewrite GWT-56b/c/d as artifact-presence (not cognitive) assertions; add new GWT-56f (scanner×input-type matrix, B.4 gap); update acceptance criteria and doc audit for 6 sub-items - slice-57: concrete product-name exclusion list for GWT-57a.2; inline all 8 module names in GWT-57b.1 - audit report: status header, temporal disclaimer, DIVIO enumeration, exec queue (56-f seq-8, renumber 57→9/58→10), Not-Now entry for setup-commands DIVIO collapse (Wave O tech debt) - DECISIONS.md: log both reviewer passes (2026-08-31) - TRAIL.md / PROGRESS.md: update slice-56 description and one-liner to reflect 6 sub-items including 56-f
code-review-graph reviewOverall risk: 0.35 (LOW) — 5 changed function(s)/class(es), 0 affected flow(s), 0 test gap(s) Risk-scored changes
Token savings: this graph-backed report used ~71,990 fewer tokens (~98%) than reading every changed file in full (estimated, chars/4 approximation). Powered by code-review-graph — local-first analysis; no code leaves the CI runner. |
…-audit - Merge extra cells in B.3/B.6/B.7/B.9/B.10 rows (7→6 cols to match header) - Replace blank line between consecutive blockquotes with bare >
…hiding them The quality filter was applied to all item types, causing MCP servers to be invisible in every view since no tab bucket matches a non-skill item. Quality tabs are a skills-only concept — non-skill items should always be visible regardless of which quality tab is active. Fix: matchesQualityTab short-circuits for non-skill items (return true). Spec: GWT-42.12/13/17 corrected to reflect pass-through intent. Tests: updated filter expectations to include MCP servers on all tabs.
…le on all tabs, not excluded Corrects CHANGELOG and README to reflect that MCP servers pass through all quality buckets (no filtering) rather than being excluded from those tabs.
…ality buckets but visible The earlier commit fixed the filter bug; these docs now correctly say MCP servers are excluded from quality score buckets (no Tessl scan) but pass through the quality tab filter and remain visible in all tab views.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Slice 55 — Disclaimer Placements
Slice 56 — Gap Repairs (6 sub-items)
Slice 57 — sync-docs Skill Update
Audit Report (`docs/plan/docs-gap-bridge-audit.md`)
TRAIL.md / PROGRESS.md / DECISIONS.md
Dashboard fix — MCP servers in quality tabs
fix(dashboard):matchesQualityTabnow short-circuitsreturn truefor non-skill items — MCP servers had no quality bucket match and were hidden on every tab (default tab wasQuality ≥ 80)docs(dashboard): CHANGELOG, README, and slice-42 spec corrected: "MCP servers are excluded from quality buckets (no Tessl score) but remain visible on all quality tabs"Test Results
Dashboard (JS prototype)
prototypes/dc-dashboard/test/tripwire-status.test.jsQuality Gates
./scripts/quality-gates.shpasses locally (pre-push hook ✅)Checklist
./scripts/quality-gates.shpasses locallyCloses
Wave N planning phase — all reviewer blockers resolved. Execution of slices 55/56/57 is deferred until slice-44 (PR #99) merges to `main`.