Draft
Conversation
lbeschastny
reviewed
Apr 22, 2026
Comment on lines
+17
to
+24
| pub(crate) struct UrlParts { | ||
| pub(crate) full_url: Option<String>, | ||
| pub(crate) path: String, | ||
| pub(crate) host: Option<String>, | ||
| pub(crate) scheme: Option<String>, | ||
| pub(crate) port: Option<u16>, | ||
| pub(crate) query: Option<String>, | ||
| } |
Collaborator
There was a problem hiding this comment.
The issue here is that hyper uses http::Uri, while reqwest relies on url::Url instead.
I suggest we define some trait to represent any Url-like structure and then implement it for both.
The trait should just return all those values in some way (probably as &str).
I can do it if you want.
lbeschastny
reviewed
Apr 22, 2026
Comment on lines
+3
to
+4
| //! This module instruments `hyper::client::conn::http1::SendRequest` and | ||
| //! `hyper::client::conn::http2::SendRequest`. |
Collaborator
There was a problem hiding this comment.
We'll have to instrument hyper_util::client::legacy::Client as well, ideally behind an additional feature
Collaborator
There was a problem hiding this comment.
The reason why we may want a separate feature is because it's guarded by the "client" feature in hyper
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
from_partsnow takes anUrlPartsstruct instead because the url types used in reqwest and hyper differ. Maybe you rather want us to parse from one to the other type instead.. 🤷