fix: mypy strict error on _inv_map union type in _vocab_cache init#4
Merged
Conversation
Add assert self._inv_map is not None before the dict comprehension so mypy can narrow the union type. Also removes the unused type: ignore comment that was on the wrong line.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add assert self._inv_map is not None before the dict comprehension so mypy can narrow the union type. Also removes the unused type: ignore comment that was on the wrong line.
Description
Type of change
Checklist
ruff formatandruff checkon changed filesmypy tinybpe/ --strictand no new errors were introducedpytest tests/)pytest --cov=tinybpe tests/)