Fix browser crash on signup rounds admin page#11178
Merged
Conversation
Fixes a browser crash that occurred when viewing the signup rounds admin page with a signup round that has a null start date. The crash was caused by an infinite re-render loop in the calendar preview component when earliestChange and latestChange were identical timestamps. This happened because: 1. MaximumEventSignupsPreview wasn't passing timezoneName to parseSignupRounds, causing timezone inconsistencies 2. ScheduledValuePreview didn't handle the case where there's only a single change point (not a time range) Changes: - MaximumEventSignupsPreview: Pass timezoneName to parseSignupRounds and include it in useMemo dependencies - ScheduledValuePreview: Add guard to skip calendar rendering when earliestChange === latestChange Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Contributor
Code Coverage Report: Only Changed Files listed
Minimum allowed coverage is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a browser crash that occurred when viewing the signup rounds admin page with a signup round that has a null start date.
Problem
The browser tab would completely crash when navigating to
/signup_rounds, making the page completely inaccessible. This was reproducible on alarpfestival2026 development environment.Root Cause
The crash was caused by an infinite re-render loop in the
ScheduledValuePreviewcalendar component. When a signup round hasstart: null, the calendar preview would calculate that bothearliestChangeandlatestChangewere the same timestamp (the only finish date in the data). This caused the component to continuously re-render, eventually crashing the browser tab.Additionally,
MaximumEventSignupsPreviewwasn't passingtimezoneNametoparseSignupRounds, which could cause timezone inconsistencies.Changes
timezoneNametoparseSignupRoundsand include it inuseMemodependenciesearliestChange === latestChange(single point in time rather than a range)Test Plan
🤖 Generated with Claude Code