Skip to content

[WIP] Update README to include pull request URL - #6

Closed
neilalb16 with Copilot wants to merge 39 commits into
add_v9_optionsfrom
copilot/update-readme-with-pull-request-url
Closed

[WIP] Update README to include pull request URL#6
neilalb16 with Copilot wants to merge 39 commits into
add_v9_optionsfrom
copilot/update-readme-with-pull-request-url

Conversation

Copilot AI commented Apr 4, 2026

Copy link
Copy Markdown
  • Analyzed PR Close: Unrelated issue filed against wrong repository #4: "Close: Unrelated issue filed against wrong repository"
  • Confirmed the referenced issue ("Canbus reboot in Lexus gs350 2007") is about automotive CAN bus electronics and has no relation to this Python NetFlow/IPFIX network monitoring library
  • Verified PR Close: Unrelated issue filed against wrong repository #4 explicitly states: "No code changes are applicable or appropriate"
  • No code changes needed — the requirements of the problem statement are already satisfied by the existing repository state

bitkeks and others added 30 commits May 2, 2021 16:15
…ess, compare the keys (which are integers) instead of values (strings)
… IP addresses to integers first, we construct them from bytes directly
…uct.unpack to extract all of the values at once)
Includes fixes for enterprise bit flag and templatefield type check.
There's no 3.9.3, only 3.9.2, which is also the correct Debian version.

3.11.1 is available in pyenv 2.3.8, but 2.3.7 is currently in use by the
  Github action. So 3.11 is used, which uses the latest patch version
commit 63abf52

    Padding: add offset!=length check to reduce safety check calls

    Adds another check when parsing a set. The check "offset !=
    self.header.length" allows to skip the padding checks if the offset is
    the same as the length, not calling rest_is_padding_zeroes and wasting
    CPU time.

commit 8d1cf9c

    Finish IPFIX padding handling

    Tested implementation of IPFIX set padding handling. Uses TK-Khaw's
    proposed no_padding_last_offset calculation, extended as modulo
    calculation to match multiple data set records.

    Tests were conducted by capturing live traffic on a test machine with
    tcpdump, then this capture file was read in by softflowd 1.1.0, with the
    collector.py as the export target. The exported IPFIX (v10) packets were
    then using both no padding and padding, so that tests could be
    validated.

    Closes bitkeks#34

    Signed-off-by: Dominik Pataky <software+pynetflow@dpataky.eu>

commit 51ce4ea

    Fix and optimize padding calculation for IPFIX sets.
    Refs bitkeks#34

commit 9d3c413
Author: Khaw Teng Kang <tk.khaw@attrelogix.com>
Date:   Tue Jul 5 16:29:12 2022 +0800

    Reverted changes to template_record, data_length is now computed using field length in template.

    Signed-off-by: Khaw Teng Kang <tk.khaw@attrelogix.com>

commit 3c4f8e6

    IPFIX: handle padding (zero bytes) in sets

    Adds a check to each IPFIX set ID branch, checking if the rest of the
    bytes in this set is padding/zeroes.

    Refs bitkeks#34

Signed-off-by: Dominik Pataky <software+pynetflow@dpataky.eu>
Copilot AI requested a review from neilalb16 April 4, 2026 17:47
Copilot stopped work on behalf of neilalb16 due to an error April 4, 2026 17:47
@neilalb16
neilalb16 changed the base branch from copilot/canbus-reboot-lexus-gs350-again to add_v9_options April 4, 2026 19:11
@neilalb16
neilalb16 marked this pull request as ready for review April 5, 2026 00:12
@neilalb16 neilalb16 closed this Apr 5, 2026
@neilalb16
neilalb16 deleted the copilot/update-readme-with-pull-request-url branch April 14, 2026 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants