-
Notifications
You must be signed in to change notification settings - Fork 148
Action/Generate: Add relocatable option #449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fgaz-scrive
wants to merge
2
commits into
ndmitchell:master
Choose a base branch
from
scrive:relocatable
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -122,8 +122,13 @@ readHaskellOnline timing settings download = do | |||||
| pure (cbl, want, source) | ||||||
|
|
||||||
|
|
||||||
| readHaskellDirs :: Timing -> Settings -> [FilePath] -> IO (Map.Map PkgName Package, Set.Set PkgName, ConduitT () (PkgName, URL, LBStr) IO ()) | ||||||
| readHaskellDirs timing settings dirs = do | ||||||
| readHaskellDirs | ||||||
| :: Timing | ||||||
| -> Settings | ||||||
| -> Maybe FilePath -- ^ Prefix to remove from URLs to make the DB relocatable | ||||||
| -> [FilePath] | ||||||
| -> IO (Map.Map PkgName Package, Set.Set PkgName, ConduitT () (PkgName, URL, LBStr) IO ()) | ||||||
| readHaskellDirs timing settings prefixToRemove dirs = do | ||||||
| files <- concatMapM listFilesRecursive dirs | ||||||
| -- We reverse/sort the list because of #206 | ||||||
| -- Two identical package names with different versions might be foo-2.0 and foo-1.0 | ||||||
|
|
@@ -135,7 +140,9 @@ readHaskellDirs timing settings dirs = do | |||||
| let source = forM_ packages $ \(name, file) -> do | ||||||
| src <- liftIO $ bstrReadFile file | ||||||
| dir <- liftIO $ canonicalizePath $ takeDirectory file | ||||||
| let url = "file://" ++ ['/' | not $ "/" `isPrefixOf` dir] ++ replace "\\" "/" dir ++ "/" | ||||||
| let url = case prefixToRemove of | ||||||
| Just prefix -> makeRelative prefix $ replace "\\" "/" dir ++ "/" | ||||||
| Nothing -> "file://" ++ ['/' | not $ "/" `isPrefixOf` dir] ++ replace "\\" "/" dir ++ "/" | ||||||
| when (isJust $ bstrSplitInfix (bstrPack "@package " <> bstrPack (unPackageName name)) src) $ | ||||||
| yield (name, url, lbstrFromChunks [src]) | ||||||
| pure (Map.union | ||||||
|
|
@@ -239,12 +246,18 @@ actionGenerate g@Generate{..} = withTiming (if debug then Just $ replaceExtensio | |||||
| Haskell | Just dir <- haddock -> do | ||||||
| warnFlagIgnored "--haddock" "set" (local_ /= []) "--local" | ||||||
| warnFlagIgnored "--haddock" "set" (isJust download) "--download" | ||||||
| warnFlagIgnored "--haddock" "set" (isJust relocatable) "--relocatable" | ||||||
| readHaskellHaddock timing settings dir | ||||||
| | [""] <- local_ -> do | ||||||
| warnFlagIgnored "--local" "used as flag (no paths)" (isJust download) "--download" | ||||||
| readHaskellGhcpkg timing settings | ||||||
| | Just _ <- relocatable, _:_ <- local_ -> | ||||||
| exitFail "Error: --relocatable and --local are mutually exclusive" | ||||||
| | Just relocatable' <- relocatable -> do | ||||||
| prefix <- traverse canonicalizePath relocatable | ||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could it be
Suggested change
? |
||||||
| readHaskellDirs timing settings prefix [relocatable'] | ||||||
| | [] <- local_ -> do readHaskellOnline timing settings doDownload | ||||||
| | otherwise -> readHaskellDirs timing settings local_ | ||||||
| | otherwise -> readHaskellDirs timing settings Nothing local_ | ||||||
| Frege | [] <- local_ -> readFregeOnline timing doDownload | ||||||
| | otherwise -> errorIO "No support for local Frege databases" | ||||||
| (cblErrs, popularity) <- evaluate $ packagePopularity cbl | ||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we please factor out
replace "\\" "/" dir ++ "/"so that it's not repeated?