WIP: Test the elixir functions#9
Open
cmush wants to merge 4 commits into
Open
Conversation
ignore native/id3/.cargo/config
update .gitignore
Author
|
@ndac-todoroki are you able to provide the original file with which you wrote the doctests? |
include test mp3 file
ndac-todoroki
left a comment
ndac-todoroki
left a comment
Owner
There was a problem hiding this comment.
This is one option, but tag writing tests may be done at new files:
- create empty mp3 files with random names in
setupwithFile.write - test writing tags
- delete all files in
after_suite, so it could be batch deleted
this way, tests could be divided and done async without worrying about IO conflicts!
Comment on lines
+30
to
+31
| .DS_Store | ||
| priv/.DS_Store No newline at end of file |
Owner
There was a problem hiding this comment.
I think this should go to your local $GIT_DIR/info/exclude or core.excludesFile, since this is specific to macOS systems.
https://git-scm.com/docs/gitignore
Owner
The current documents were not for doctests, so there are no original files 😢 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
run
mix test test/id3v2_test.exs