Conversation
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (68.16%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #160 +/- ##
==========================================
+ Coverage 57.71% 59.09% +1.37%
==========================================
Files 64 74 +10
Lines 10104 11386 +1282
Branches 1754 1970 +216
==========================================
+ Hits 5832 6729 +897
- Misses 3520 3828 +308
- Partials 752 829 +77
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This was referenced Sep 23, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Damacy currently requires CUDA even when the consumer needs a tensor in host memory. This change adds a CPU executor and explicit pipeline components so existing rectangular queries share metadata loading and chunk planning, then execute on either CPU or CUDA.
Benchmark uncertainty: median CUDA throughput is 5.8% below the baseline in three paired L40 runs (12.409 to 11.684 GB/s). Baseline runs themselves span about 6%, and shared NFS traffic was not controlled. This is an inconclusive throughput difference; these measurements do not establish a code regression or performance parity.
Behavior change: a DLPack view now keeps its output buffer until the view is destroyed, even after its
Batchis released. Previously the buffer returned to the pool while views could still see it, so a kept tensor was silently overwritten by a later batch. Code that keeps views from two batches now raisesPoolStarved; use.clone()(PyTorch) or.copy()(NumPy) to keep data.Implementation
Pipeline(Config(...))anddamacy_createas CUDA construction adapters.f32orbf16results.Index queries and transformed crops remain future work. The architecture document describes ordered per-dimension indices, NGFF level selection during query resolution, and sampler/interpolation/boundary settings carried by spatial queries.
Validation
Measurements and limits
The throughput workload produces 1 GiB of
f32crops per batch from sharded zstd arrays. With 16 decode workers, CPU useful-output throughput reaches 4.104 GB/s with 2.019 GiB peak RAM. CPU measurements use shared filesystem caches and one run per worker count; they are not cold-storage or training-loop measurements. The executor memory limit covers its buffers and codec workspace, not total process RSS.The CUDA comparison alternates three baseline/refactor pairs on one L40 with matching compilers, flags, context setup, and input seeds. GDS and NUMA placement were unavailable on the test host and remain unvalidated here.
API examples and lifetime contracts · Architecture and future queries · Complete validation and measurements