Updated to allow px, %, vw and vh units for translate properties#57
Open
sambadave wants to merge 1 commit intonckprsn:masterfrom
Open
Updated to allow px, %, vw and vh units for translate properties#57sambadave wants to merge 1 commit intonckprsn:masterfrom
sambadave wants to merge 1 commit intonckprsn:masterfrom
Conversation
Based on % fix from @yoannisj.
Author
|
I have updated this based on #28 from yoannisj to also allow px, %, vw and vh units in the translate property. vw and vh properties work quite nicely across desktop/tablet/mobile as they are based on the viewport size and not a pixel or % value which can give undesired results across different viewport sizes. N.B I'm no javascript expert so this could probably be written better than I have done! Thanks @yoannisj for the initial % fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on % fix from @yoannisj.
Updated to allow px, %, vw and vh units in translate property.