fix support for jQuery 3.0.0 and build tool to minify scrollme#35
Open
dotnetCarpenter wants to merge 1 commit intonckprsn:masterfrom
Open
fix support for jQuery 3.0.0 and build tool to minify scrollme#35dotnetCarpenter wants to merge 1 commit intonckprsn:masterfrom
dotnetCarpenter wants to merge 1 commit intonckprsn:masterfrom
Conversation
|
Thanks! Fixed my issue. |
|
I've downloaded the version you fixed. But still it's not working. Do I have to copy any file other than jquery.scrollme.js? I'm using gulp to build the minification. |
Author
|
@subhasisghosal Not sure what error you are getting. So can't tell you. But no, you would normally not need anything else than https://github.com/Firefund/scrollme/blob/jquery3/jquery.scrollme.js. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #34
Tested in Chrome 50 and Firefox 47
This features a simple build tool (uglify2) - just run the command
npm run buildto get a minified version ofjquery.scrollme.js. Based on npm, so there is now apackage.json.Other fixes include, pointing bower main to an unminified version per specification and only running the initialization code once.
The version has been bumped to version 1.1.1 - so all you need to do is
git tag v1.1.1 -am "Support for jQuery3" && git push --tagCheers!
PS. We will run off our fork (https://github.com/Firefund/scrollme) until this is merged.
My commit (c5ed23a) is signed with my public pgp key if you want to verify (github should already be doing this - if you look in the commit history) you can download my key from https://github.com/Firefund/frontend/blob/master/MAINTAINERS/dotnetCarpenter.asc