Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/sobelow.ex
Original file line number Diff line number Diff line change
Expand Up @@ -291,6 +291,10 @@ defmodule Sobelow do
Application.get_env(:sobelow, key)
end

def put_env(key, value) do
Application.put_env(:sobelow, key, value)
end

defp print_banner do
"""
##############################################
Expand Down
2 changes: 1 addition & 1 deletion lib/sobelow/parse.ex
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ defmodule Sobelow.Parse do
if Sobelow.get_env(:skip) do
String.replace(
content,
~r/#\s?sobelow_skip (\[(\"[^"]+\"(,|, )?)+\])/,
~r/#\s?sobelow_skip (\[(\"[^"]+?\"(,|, )?)+?\]).*/,
"@sobelow_skip \\g{1}"
)
else
Expand Down
8 changes: 8 additions & 0 deletions test/fixtures/parser/parse_skip.ex
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
defmodule Mod do
@moduledoc false

# sobelow_skip ["Foo"] (no foo violations here)
def func() do
:ok
end
end
12 changes: 12 additions & 0 deletions test/parser_test.exs
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ defmodule SobelowTest.ParserTest do
use ExUnit.Case
import ExUnit.CaptureIO
alias Sobelow.RCE.CodeModule
alias Sobelow.Parse

@metafile %{filename: "test.ex", controller?: true}

Expand All @@ -27,4 +28,15 @@ defmodule SobelowTest.ParserTest do

assert capture_io(run_test) =~ "Code Execution in `Code.eval_string` - Medium Confidence"
end

test "Remainder of line after sobelow_skip expression is ignored" do
Sobelow.put_env(:skip, true)
file = "./test/fixtures/parser/parse_skip.ex"

%{def_funs: defs} = Parse.ast(file)
|> Parse.get_meta_funs()
assert not Enum.empty?(defs)
after
Sobelow.put_env(:skip, false)
end
end