Repository navigation
V73 - #143
Merged
Merged
V73#143
Conversation
Replace stale boolean tracking with failedLinks array and cy.then() assertion that properly fails tests when links return error statuses.
Simplify from 152 lines to 56 by removing unused types, interfaces, and NCA_CONFIG that could never change the outcome of the check.
domainMapping.ts was never imported by any command. Delete the source, dist artifacts, and test file.
Use declare global { namespace Cypress } so augmentation works in
module context. Remove unused DomainMappingConfig interface. Align
all command signatures with actual implementations.
Replace fragile split('@') approach with existing extractAuth/applyAuth
functions that properly handle edge cases via the URL constructor.
Add cy.then mock and tests verifying the final assertion behavior with both valid and invalid link statuses.
When validating images on subpages, broken image errors now show which
page the image was found on, making it much easier to debug 404s during
multi-page crawls. The error message format is now structured as:
Image validation failed on page: <page URL>
Image URL: <broken image>
Status: <code>
Source: <element details>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.