Repository navigation
Release 2.2.1: dyode_in/dyode_out optional with transport: air - #10
Merged
Merged
Conversation
- dyode check prints "network: not used (transport: air)" instead of the placeholder addresses. - The API's diode-NIC guard is skipped for air: there is no diode NIC, and the default interface name could refuse the real management NIC. - Test for the guard on both transports; docs/AIR.md note; version 2.2.1, dated CHANGELOG. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018Q4FHhHAFgBUCsPf3UW67z
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release 2.2.1, a small fix found during the first hardware test of
transport: air: Ubuntu 24.04 → Raspberry Pi 3 over wfb-ng, with 20 MB and 30 MB files delivered with identical SHA-256.With air there is no diode NIC, so the
dyode_in/dyode_outsections can be left out of config.yaml. Two leftovers of those sections are fixed:dyode checkprinted placeholder addresses (network: in 10.0.1.1 (eth0) -> out 10.0.1.2 (eth1)). It now printsnetwork: not used (transport: air).dyode_in/dyode_out. With the sections omitted, the defaulteth0on the input side could refuse the box's real management NIC. The guard is now skipped for air; lidi is unchanged.Also: a unit test for the guard on both transports, a note in docs/AIR.md, version 2.2.1, and a dated CHANGELOG entry.
Test plan
cargo fmt --check,cargo clippy --all-targets -D warningscargo test: 83 unit tests (1 new) andtests/air.rstools/check_release.sh v2.2.1passes (dated 2026-11-15)dyode_in/dyode_out) ran on real hardware with the 2.2.0 binariesv2.2.1Generated by Claude Code