Repository navigation
Fixed diff dialog appearing as orphan tab when Claude edits outside cwd - #92
Merged
oleg68 merged 1 commit intoApr 25, 2026
Merged
Conversation
When Claude cd's into a subdirectory mid-session, the PreToolUse hook fires with cwd = that subdirectory. The session tab lookup used abs.equals(hookCwd), which failed because the tab's startup dir is the project root — not the subdir Claude cd'd into. This left sessionTab = null, causing: - diff opening as a detached top-level tab instead of embedded in session - Cancel and Accept-All buttons disabled - false "outside project" warning for files in the project root Fix: change lookup condition to isFileUnderDirectory(hookCwd, abs) so a tab matches when its startup dir is an ancestor of hookCwd. Also compute outsideProject against the tab's startup dir (project root) rather than hookCwd, and rename the parameter confirmedDir → hookCwd. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
5 tasks
oleg68
added a commit
that referenced
this pull request
Apr 25, 2026
…wd (#93) Backport of #92 to release/0.21. ## Summary - Fixed diff dialog opening as a detached top-level tab (instead of embedded in session) when Claude `cd`'s into a subdirectory mid-session and then edits a file outside that subdirectory - Root cause: session tab lookup used `abs.equals(hookCwd)` — failed because tab's startup dir (project root) ≠ hook's `cwd` (subdir Claude cd'd into), leaving `sessionTab = null` - Fix: changed condition to `isFileUnderDirectory(hookCwd, abs)`; outsideProject now uses the tab's startup dir; renamed parameter `confirmedDir` → `hookCwd` ## Test plan - [ ] Open a Claude session with the project root as the working directory - [ ] In the session, run `cd <subdirectory>` - [ ] Ask Claude to edit a file in the project root (`src/main/java/...`) - [ ] Confirm: diff opens **embedded** in the session tab, Cancel and Accept-All buttons are active, no "outside project" warning - [ ] Confirm: warning still appears for a file truly outside the project 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Oleg Samarin <osamarin@openintegration.inc> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cd's into a subdirectory mid-session and then edits a file outside that subdirectoryabs.equals(hookCwd)— failed because tab's startup dir (project root) ≠ hook'scwd(subdir Claude cd'd into), leavingsessionTab = nullisFileUnderDirectory(hookCwd, abs)(tab matches when its startup dir is an ancestor of hookCwd); outsideProject now uses the tab's startup dir, not hookCwd; renamed parameterconfirmedDir→hookCwdTest plan
cd <subdirectory>(e.g.claude-launch-tests)src/main/java/...)/tmp/file.txt)🤖 Generated with Claude Code