Skip to content

Fixed choice menu not recognizing Ultraplan "Tell Claude what to change" as text input - #91

Merged
oleg68 merged 1 commit into
nbplugins:release/0.21from
oleg68:feature/0.21/ultraplan-tell-claude-text-input
Apr 25, 2026
Merged

oleg68 merged 1 commit into
nbplugins:release/0.21from
oleg68:feature/0.21/ultraplan-tell-claude-text-input

Conversation

@oleg68

@oleg68 oleg68 commented Apr 25, 2026

Copy link
Copy Markdown
Collaborator

Backport of #90 to release/0.21.

Summary

  • The Ultraplan plan-review menu option "Tell Claude what to change" was rendered as a plain radio button instead of a text input field
  • Fixed by adding hasTextInput field to ChoiceMenuModel.Option, detecting "shift+tab to approve" hint lines in ScreenContentDetector, and extending isTypeInputOption in ChoiceMenuPanel

Test plan

  • ScreenContentDetectorTest passes (70 tests)
  • mvn package passes
  • In NetBeans: trigger Ultraplan plan-review menu, verify option 4 renders with a text field

🤖 Generated with Claude Code

…ge" as text input

The Ultraplan plan-review menu option "Tell Claude what to change" was rendered
as a plain radio button instead of a text input field. The "shift+tab to approve
with this feedback" sub-line was incorrectly stored as the option's description
rather than being treated as a hint that marks the option as hasTextInput.

Fixes:
- ScreenContentDetector: added "shift+tab" to isHintLine; when a "shift+tab to
  approve" line is detected below an option, sets hasTextInput=true on that option
- ChoiceMenuModel.Option: added hasTextInput field (mirrors existing hasCheckbox pattern)
- ChoiceMenuPanel.isTypeInputOption: also returns true for opt.hasTextInput()

Python investigation confirmed that the existing TYPE:N:text mechanism (digit +
text + \r) works correctly for this option.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@oleg68
oleg68 merged commit 31f6683 into nbplugins:release/0.21 Apr 25, 2026
3 checks passed
@oleg68
oleg68 deleted the feature/0.21/ultraplan-tell-claude-text-input branch April 25, 2026 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant