Repository navigation
Fixed --continue passed even when no sessions exist for the directory - #8
Merged
Merged
Conversation
When SessionMode.CONTINUE_LAST was selected, claude --continue was unconditionally appended. If no prior sessions existed for the working directory, the CLI would fail. Fix: extracted appendSessionFlags() from start(), added ClaudeSessionStore.hasAnySessions() (file-existence check, no parsing), and guard --continue behind it — falls back to a new session silently. Fixed tab not closing when CLOSE_ONLY is selected in SaveAndSwitchDialog After stopping and renaming a session, the tab now closes itself via `doCloseTab()` (which calls `TopComponent.close()`). A protected hook method was introduced to make the behaviour testable without the full NetBeans platform. Added "Restart Advanced..." option to Save & Switch dialog Stops the current session and returns to the selector panel in the same tab, allowing full reconfiguration (directory, profile, mode) before starting a new session. Also fixed a bug where selecting "Resume specific" in the selector panel showed an empty session list until the profile was changed. Root cause: reloadSessionModePanel() only updated SessionModePanel when mode was already RESUME_SPECIFIC, so the stored workingDir was stale. Fix: always update SessionModePanel on directory/profile changes, and also refresh on pathCombo changes. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When SessionMode.CONTINUE_LAST was selected, claude --continue was unconditionally appended. If no prior sessions existed for the working directory, the CLI would fail.
Fix: extracted appendSessionFlags() from start(), added ClaudeSessionStore.hasAnySessions() (file-existence check, no parsing), and guard --continue behind it — falls back to a new session silently.
Fixed tab not closing when CLOSE_ONLY is selected in SaveAndSwitchDialog
After stopping and renaming a session, the tab now closes itself via
doCloseTab()(which callsTopComponent.close()). A protected hook method was introduced to make the behaviour testable without the full NetBeans platform.Added "Restart Advanced..." option to Save & Switch dialog
Stops the current session and returns to the selector panel in the same tab, allowing full reconfiguration (directory, profile, mode) before starting a new session.
Also fixed a bug where selecting "Resume specific" in the selector panel showed an empty session list until the profile was changed. Root cause: reloadSessionModePanel() only updated SessionModePanel when mode was already RESUME_SPECIFIC, so the stored workingDir was stale. Fix: always update SessionModePanel on directory/profile changes, and also refresh on pathCombo changes.