Repository navigation
Backport/issue 23/0.20 - #37
Merged
Merged
Conversation
autoStart(File, String) was passing null as extraCliArgs to the three-argument overload, so the profile's Extra CLI args setting (configured in Tools → Options → Profiles) was silently discarded when launching from the project context menu. Fix: resolve the profile via ClaudeProfileStore.findByName() and forward its extraCliArgs. The IDE-restore path (autoStart with three args) already passes savedExtraCliArgs correctly and is unaffected. Resolves: nbplugins#23 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…cked Default ClaudeProfile.createDefault() constructs a profile with all fields set to empty defaults without reading NbPreferences. As a result, findByName(null/blank) returned a bare Default profile, silently discarding the user's configured API key, proxy, extraCliArgs, and other settings. Fix: - Added ClaudeProfileStore.getDefaultProfile() that goes through getProfiles(), which applies stored settings from NbPreferences to the Default profile. - findByName() now delegates to getDefaultProfile() for null/blank names, and uses it as the fallback for unknown named profiles. - Removed unused resolveProfile() from ClaudeProjectProperties (dead code). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
autoStart(File, String) was passing null as extraCliArgs to the
three-argument overload, so the profile's Extra CLI args setting
(configured in Tools → Options → Profiles) was silently discarded when
launching from the project context menu.
Fix: resolve the profile via ClaudeProfileStore.findByName() and forward
its extraCliArgs. The IDE-restore path (autoStart with three args)
already passes savedExtraCliArgs correctly and is unaffected.
ClaudeProfile.createDefault() constructs a profile with all fields set
to
empty defaults without reading NbPreferences. As a result,
findByName(null/blank)
returned a bare Default profile, silently discarding the user's
configured
API key, proxy, extraCliArgs, and other settings.
Fix:
getProfiles(),
which applies stored settings from NbPreferences to the Default profile.
names,
and uses it as the fallback for unknown named profiles.
code).
Resolves: #23
Co-authored-by: Oleg Samarin osamarin@openintegration.inc
Co-authored-by: Claude Sonnet 4.6 noreply@anthropic.com