Skip to content

Fixed session tab blocking resize below ~600px when docked as side panel - #35

Merged
oleg68 merged 1 commit into
nbplugins:mainfrom
oleg68:bugfix/issue-19-min-size
Apr 14, 2026
Merged

oleg68 merged 1 commit into
nbplugins:mainfrom
oleg68:bugfix/issue-19-min-size

Conversation

@oleg68

@oleg68 oleg68 commented Apr 13, 2026

Copy link
Copy Markdown
Collaborator

southCard.getMinimumSize() was delegating to its visible child (promptPanel with a 3-row text area + buttons), which reported a tall minimum height. JSplitPane enforces the bottom component's minimum, so the divider bounced back when the user tried to shrink the tab below that height.

Fix: override getMinimumSize() in southCard to always return (0, 0), letting JSplitPane collapse the bottom panel freely. getPreferredSize() is unchanged so the panel still requests its natural height when space allows.

Resolves: #19

@oleg68
oleg68 force-pushed the bugfix/issue-19-min-size branch from c32bf04 to 6788e83 Compare April 14, 2026 06:44
southCard.getMinimumSize() was delegating to its visible child (promptPanel
with a 3-row text area + buttons), which reported a tall minimum height.
JSplitPane enforces the bottom component's minimum, so the divider bounced
back when the user tried to shrink the tab below that height.

Fix: override getMinimumSize() in southCard to always return (0, 0),
letting JSplitPane collapse the bottom panel freely. getPreferredSize() is
unchanged so the panel still requests its natural height when space allows.

Resolves: nbplugins#19

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@oleg68
oleg68 force-pushed the bugfix/issue-19-min-size branch from 6788e83 to 735de2d Compare April 14, 2026 18:38
@oleg68
oleg68 merged commit 707db92 into nbplugins:main Apr 14, 2026
3 checks passed
@oleg68
oleg68 deleted the bugfix/issue-19-min-size branch April 14, 2026 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Session tab cannot be resized below ~600px when docked as a side panel, steals space from the editor

1 participant