Repository navigation
Fixed MCP config not working on Windows due to quote stripping (#13) (#17) - #32
Merged
oleg68 merged 4 commits intoApr 13, 2026
Merged
Conversation
…gins#13) (nbplugins#17) Resolves: nbplugins#13 Write --mcp-config JSON to a temp file instead of passing inline JSON, avoiding Windows CreateProcess quote-stripping. The temp file is deleted when the session stops. Also fixed error panel cleanup: hang detection now calls killOnly() instead of stop(), so settings.local.json and the temp MCP config file are preserved until the error panel is dismissed (stopProcess() on panel close triggers full file cleanup). Co-authored-by: Oleg Samarin <osamarin@openintegration.inc> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
… timeout (nbplugins#11) Watchdog fires in the existing 500 ms pollScreenState() timer: if no PTY bytes arrive within the configured timeout after launch, the process is stopped and the error panel is shown with the elapsed-time message. - ClaudeCodePreferences: KEY_HANG_TIMEOUT_SECONDS (default 60, 0=disabled) - ClaudeCodeOptionsPanel: hang timeout spinner on General tab (0–3600 s) - ClaudeSessionController: processStartedAt / firstOutputReceived fields, hang check in pollScreenState(), handleHang() + setHangCallback() - ClaudeSessionTab: wires controller.setHangCallback(this::showStartError) - ClaudeSessionControllerTest: 4 new tests for hang-detection logic Co-authored-by: Oleg Samarin <osamarin@openintegration.inc> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-authored-by: Oleg Samarin <osamarin@openintegration.inc> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
oleg68
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #13
Write --mcp-config JSON to a temp file instead of passing inline JSON,
avoiding Windows CreateProcess quote-stripping. The temp file is deleted
when the session stops.
Also fixed error panel cleanup: hang detection now calls killOnly()
instead of stop(), so settings.local.json and the temp MCP config file
are preserved until the error panel is dismissed (stopProcess() on panel
close triggers full file cleanup).
Co-authored-by: Oleg Samarin osamarin@openintegration.inc
Co-authored-by: Claude Sonnet 4.6 noreply@anthropic.com