Skip to content

Fixed edit-mode detection and switching while background agents or shells are listed under the status line - #203

Merged
oleg68 merged 1 commit into
nbplugins:mainfrom
oleg68:bugfix/edit-mode-agent-panel
Oct 27, 2026
Merged

oleg68 merged 1 commit into
nbplugins:mainfrom
oleg68:bugfix/edit-mode-agent-panel

Conversation

@oleg68

@oleg68 oleg68 commented Oct 27, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Newer Claude Code versions render an agent panel (● main + one row per agent) below the mode footer, pushing it out of the bottom-3-lines window of ScreenContentDetector. The mode became unknown, Shift+Tab switching went blind, and a working session was reported READY.
  • Added stripAgentPanel(), which cuts the panel (only below the input prompt, so a ● main line in the response is never cut) before detectEditMode() and detectSessionState().
  • Added fixtures for two real screens plus unit tests (all four modes, 1/5/10 agents, negative case).

Test plan

  • mvn package — 1161 tests, 0 failures
  • Run background agents/shells so the panel appears, switch mode via the combo box in both directions, confirm it lands on the target without overshoot
  • Send button stays disabled while agents work

🤖 Generated with Claude Code

…ells are listed under the status line

The agent panel (`● main` plus one row per agent) pushed the mode footer out of the
bottom-3-lines window, so the mode was unknown and the session looked READY while
working. stripAgentPanel() now cuts the panel (below the input prompt only) before
detectEditMode() and detectSessionState() run.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-27T18:58:31.704468Z cbe72fc PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@oleg68
oleg68 merged commit 08d2e16 into nbplugins:main Oct 27, 2026
3 checks passed
@oleg68
oleg68 deleted the bugfix/edit-mode-agent-panel branch October 27, 2026 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant