Repository navigation
Fixed the edit-mode selector with Claude Code 2.1.x - #195
Conversation
Signed-off-by: Muhammad Rizky Rizaldi <myquinn489@gmail.com>
The mode-switch worker now also catches RuntimeException, so an unchecked exception (e.g. connector nulled on session stop) no longer leaves modeSwitchInProgress stuck and blocks later switches. sendShiftTab() no longer clears the flag while a worker owns it. The racy retarget test is now deterministic (CountDownLatch). The capture script exits with a clear message when claude is not on PATH. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3828e9ae7f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
… fails The Shift+Tab worker used to clear the shared target on any failure and exit, so a newer mode requested during the failed switch was never served. It now logs the failure and continues with the queued target; only an interrupt stops the worker and clears the state. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 610b00f992
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The worker decided that its request was done by comparing the queued target with its own by value, so an A -> B -> A sequence during a failing switch to A looked like the original request and was cleared. Requests now carry a generation number and the worker compares generations instead. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Supersedes #193 (rebased onto current
main, review comments addressed). Original work by @Rizky92 — their commit is kept with authorship.Problem
● high · /effortbelow the mode footer line, so the mode was never detected when idle and the combo jumped to "Ask on Edit".Fix
ScreenContentDetector.detectEditMode: after the bottom-most line, falls back to the 2 lines above, only if they start with⏸/⏵. Old layouts are checked first, with unchanged rules.ClaudeSessionController: single worker with a retargetableeditModeSwitchTarget.Review fixes (on top of the original commit)
RuntimeException, so the in-progress flag is never stuck (new test).CountDownLatch.sendShiftTab()no longer clearsmodeSwitchInProgresswhile a worker owns it.claudeis not on PATH.mvn package: 1140 tests, 0 failures.🤖 Generated with Claude Code