Repository navigation
Fixed unnumbered choice prompts showing every line as a bogus option - #178
Merged
oleg68 merged 1 commit intoSep 30, 2026
Merged
Conversation
…ery line as a bogus option detectUnnumberedChoiceMenu skipped blank lines unconditionally while scanning upward for options, so it swept an entire dialog's blank-separated prose into the options list once no box-drawing boundary was present. It also unconditionally merged any two adjacent non-blank lines into one option, fusing the real "Yes" choice into the "No" option's description. Now the upward scan stops on the first blank line encountered after at least one option block has been collected, and two lines are only merged into one (main, desc) option when the lower line carries the "·" metadata separator used by real 2-line entries (e.g. the /resume picker). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ScreenContentDetector.detectUnnumberedChoiceMenusweeping an entire dialog's blank-separated prose (header, warning text, etc.) into the options list for unnumbered choice prompts that have no box-drawing boundary above the real options (e.g. the "trust this folder" dialog) — every line was rendered as its own bogus radio button.trust-folder-prompt.src.txt/.expectedRes.json) reproducing the exact reported screen.Test plan
mvn test— full suite passes (0 failures/errors), including all existingresume-picker-unnumbered*fixtures (unaffected) and the newtrust-folder-promptfixturemvn packagebuilds cleanly🤖 Generated with Claude Code