Repository navigation
Fixed Copy menu item being disabled in the terminal context menu when text was selected while mouse reporting was enabled - #151
Merged
Conversation
… text was selected by mouse drag while Claude Code's TUI had mouse reporting enabled JediTerm's right-click Copy is enabled iff TerminalPanel.mySelection != null at popup-build time. When the running TUI has enabled mouse reporting (DECSET 1000/1006), JediTerm forwards plain left-button drag events to the application instead of creating a local TerminalSelection — so the user sees no selection in JediTerm's model and Copy is permanently disabled. Claude Code toggles mouse reporting dynamically based on its TUI state, which is why the bug appeared profile-dependent. NetBeansSettingsProvider now overrides forceActionOnMouseReporting() to return true, which makes JediTerm's isLocalMouseAction() always true and lets mouse drag create a selection regardless of the application's mouse-tracking state. Click forwarding to the TUI is not relied upon by the plugin (option menus are handled separately by ScreenContentDetector and ChoiceMenuPanel), so suppressing it has no user-visible cost. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TerminalSelectionwhen mouse reporting is active; with no selection,TerminalPanel$12.isEnabled(null)returns false and Copy is greyed out.NetBeansSettingsProvider.forceActionOnMouseReporting()now returnstrue, soisLocalMouseAction()always returns true and drag always creates a selection. Click forwarding to the TUI is not relied upon (option menus are handled separately byScreenContentDetector/ChoiceMenuPanel).Test plan
mvn package— all 878 tests passZoomableJediTermWidget)🤖 Generated with Claude Code