Repository navigation
Fixed a Warning dialog appearing on NetBeans exit when a diff tab had been opened during the session - #144
Merged
Conversation
… been opened during the session The anonymous TopComponent subclass created in FileDiffOpener.open() inherited PERSISTENCE_ALWAYS from TopComponent, causing NetBeans to attempt serialization at shutdown. Extracted it to a named static nested class DiffTopComponent that overrides getPersistenceType() to return PERSISTENCE_NEVER. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Added V1MigrationHelper.removeStaleComponentSettings() and called it from ClaudeCodeInstaller.restored() to delete any .settings files referencing FileDiffOpener\$1 before the NetBeans window system reads them. This prevents the Warning dialog that appeared on startup when upgrading from 1.2.11 (where FileDiffOpener\$1 was serialized) to 1.2.13+ (where it is gone). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TopComponentsubclass inFileDiffOpener.open()(wasFileDiffOpener$1) into a named static nested classDiffTopComponentthat overridesgetPersistenceType()→PERSISTENCE_NEVER, preventing NetBeans from serializing it at shutdownV1MigrationHelper.removeStaleComponentSettings()and called it fromClaudeCodeInstaller.restored()to delete any stale.settingsfiles referencingFileDiffOpener$1before the window system reads them — eliminates the warning for users upgrading from older versionsFileDiffOpenerTest.diffTopComponentPersistenceTypeIsNever()Test plan
🤖 Generated with Claude Code