Repository navigation
Conversation
The EDT screen-poll timer read JediTerm's TerminalTextBuffer without holding the buffer lock while the PTY thread was writing to it, causing ConcurrentModificationException inside TerminalLine.getText(). Fixed by acquiring TerminalTextBuffer.tryLock() before reading the screen buffer. tryLock() (non-blocking) is used instead of lock() so the EDT timer never blocks waiting for a PTY write to finish — it simply returns an empty list and retries on the next tick. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TerminalTextBuffer.tryLock()before reading the screen buffer ingetScreenLines()(ClaudeSessionTab.java:1471)Root cause
The EDT screen-poll timer called
getScreenLines()which read JediTerm'sTerminalTextBufferwithout holding the buffer lock. The PTY thread writes to the same buffer concurrently, causingConcurrentModificationExceptioninsideTerminalLine.getText()→LinesBuffer.getLineTexts().tryLock()(non-blocking) is used instead oflock()so the EDT timer never blocks waiting for a PTY write — it returns an empty list and retries on the next tick.Test plan
mvn test— 858 tests passConcurrentModificationExceptioninmessages.log