Repository navigation
Fixed markdown renderer dropping content after nested list with code block - #118
Merged
Merged
Conversation
toHtml() tests now use @ParameterizedTest with .src.md / .expectedHtml.html fixture pairs under src/test/resources, matching the ScreenContentDetectorTest pattern. esc(), inlineToHtml(), and resolveImagePaths() tests remain inline. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ter nested list When a list item contained an indented code block, content after the list (headings, paragraphs, a new top-level list) was silently discarded. The firstIdx scan in the continueList branch now stops at any non-blank line rather than skipping over non-list content; the tail after the list is processed via convertSegment. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MarkdownRenderer.toHtml()silently discarding headings, paragraphs, and subsequent list items that follow an ordered/unordered list item containing an indented fenced code blockMarkdownRendererTestto fixture-based parameterized tests (@ParameterizedTest+@MethodSource), matching the pattern used inScreenContentDetectorTest; added 29 fixture pairs undersrc/test/resources/Root cause
In
toHtml(), thecontinueListbranch scannedfirstIdxpast any non-blank, non-list lines (headings, etc.), which caused that content to be silently dropped. The fix: stopfirstIdxat the first non-blank line regardless of type, then process any remaining tail viaconvertSegment.Test plan
MarkdownRendererTest— 48 tests, all greenmvn package— BUILD SUCCESSdocs/fixture.mdin the plugin preview —## Fheading now visible,Gcode block at correct top-level indentation🤖 Generated with Claude Code