Repository navigation
Fixed Bypass Permissions edit mode not suppressing the file diff dialog - #112
Merged
oleg68 merged 1 commit intoMay 12, 2026
Merged
Conversation
The edit mode was stored in EDIT_MODE_REGISTRY only when workingDirectory was already set. In startProcess(), setEditMode() is called before setWorkingDirectory(), so the registry entry was silently skipped and getEditModeForCwd() returned DEFAULT for every hook call. Fix: setWorkingDirectory() now writes the current editMode to the registry when workingDirectory is assigned and editMode is non-null. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
startProcess()calledsetEditMode()beforesetWorkingDirectory(), so the edit mode was never written toEDIT_MODE_REGISTRY(which requires a non-null working directory)getEditModeForCwd()found no entry and returnedDEFAULT, causing the diff permission dialog to appear even in Bypass Permissions modesetWorkingDirectory()now syncs the currenteditModeinto the registry when the directory is assignedTest plan
setWorkingDirectoryAfterEditModeSyncsRegistryreproduces the bug and passes with the fixClaudeSessionModelTesttests pass🤖 Generated with Claude Code