Add fail during execution and start test + bug fixes + clean up of list_containers

[Synicix]

Added

• test case for containers that fail at start due to bad command (Required some status code handling)
• test case for container that fail during execution (runtime exception)
• is_failed_to_start_pod and get_container_name func for orca for testing purposes
• names to filters when querying for container info in get_info to prevent collision with other containers
• Started and Undefined for status to deal with certain docker container status return

Other stuff:

• Copied over the new implementation for execute_wrapper and basic test implemented in Logging features for during and post run #93 for orchestration tests to deal with redundancies.
• Copied pod_result container wait error from Agent: Add configurable storage of PodResult #94 to allow test cases above to work

[Copilot]

Pull Request Overview

Adds new failure handling tests, status variants, and refactors orchestration logic to improve error reporting and cleanup.

• Introduce tests for pods that fail at start or during execution and refactor basic_test into execute_wrapper
• Extend orchestrator to report FailedToStartPod errors and new Starting/Undefined statuses, with polling for results
• Clean up container listing filters and centralize run-info extraction in core implementation

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
tests/orchestrator.rs	Refactored test helper, added failure tests, and cleaned up list assertions
src/uniffi/orchestrator/mod.rs	Added Starting/Undefined statuses and derived PartialEq on PodRun
src/uniffi/orchestrator/docker.rs	Wrapped start_container errors in a FailedToStartPod kind and added wait polling
src/uniffi/error.rs	Defined FailedToStartPod error variant and helper methods
src/core/orchestrator/docker.rs	Centralized run-info extraction and added name-based filters
src/core/error.rs	Updated Debug impl to include the new error variant

Comments suppressed due to low confidence (5)

tests/orchestrator.rs:168

• The comment says the pod should be deleted, but the assertion below checks that it exists in the list. Update the comment to match the intent, or adjust the assertion.

        // Make sure the pod has been deleted after failing to start

src/uniffi/error.rs:137

• The doc comment is incomplete. Expand it to explain when get_container_name returns Some and what it represents.

    /// Returns container name if the

src/uniffi/orchestrator/mod.rs:27

• New Starting and Undefined status variants were added but not exercised by any tests. Consider adding tests that cover these states to ensure correct handling.

    Starting,

tests/orchestrator.rs:1

• The crate-level attribute block is indented by one space, which prevents it from being applied. Move #![expect(...)] to column 0 so it’s recognized.

#![expect(

src/core/orchestrator/docker.rs:12

• There is no bollard::secret module. Import ContainerInspectResponse and ContainerSummary from bollard::models instead to compile correctly.

    secret::{ContainerInspectResponse, ContainerSummary},

[Copilot]

This assignment is immediately overwritten on the next line. Remove the redundant pod.image (and the first pod.command) to keep the test setup clear.

Suggested change

	pod.image = "alpine:3.14".to_owned();
	pod.command = "python file_does_not_exist.py".to_owned();

[codecov]

Codecov Report

❌ Patch coverage is 96.80000% with 4 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/core/orchestrator/docker.rs	97.53%	2 Missing ⚠️
src/core/error.rs	0.00%	1 Missing ⚠️
src/uniffi/error.rs	87.50%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!