refactor(ENG-379): make iter_packets() read-only, consolidate DB join sites#131

Merged

eywalker merged 26 commits intodevfrom

eywalker/eng-379-refactor-functionnode-clean-up-redundant-logic-and-ensure

Apr 7, 2026

Commits on Apr 7, 2026

docs: add FunctionNode refactor design spec (ENG-379)

kurodo3[bot]
and
claude
committed
docs(ENG-379): add implementation plan for FunctionNode refactor

kurodo3[bot]
and
claude
committed
test(ENG-379): add failing tests for read-only iter_packets semantics

kurodo3[bot]
and
claude
committed
test(ENG-379): fix unused asyncio import and misleading concurrent docstring
kurodo3[bot]
committed
test(ENG-379): remove stale asyncio.gather mention from module docstring
kurodo3[bot]
committed
feat(ENG-379): add _load_cached_entries() single DB join helper

kurodo3[bot]
and
claude
committed
refactor(ENG-379): extract entry_ids_col before join.drop() for clarity
kurodo3[bot]
committed
refactor(ENG-379): store _cached_output_packets by entry_id, remove cache_index

kurodo3[bot]
and
claude
committed
refactor(ENG-379): update _cached_output_packets type annotation to str | int for intermediate state
kurodo3[bot]
committed
refactor(ENG-379): rewrite run() with load_status guard delegating to execute()

kurodo3[bot]
and
claude
committed
refactor(ENG-379): rewrite iter_packets() as strictly read-only with DB hot-load

kurodo3[bot]
and
claude
committed
refactor(ENG-379): remove _cached_input_iterator/_needs_iterator iterator state

kurodo3[bot]
and
claude
committed
refactor(ENG-379): revert str annotation to str|int interim, remove dead iterator writes in get_cached_results
kurodo3[bot]
committed
refactor(ENG-379): simplify get_cached_results() using _load_cached_entries(), add-only semantics

kurodo3[bot]
and
claude
committed
refactor(ENG-379): simplify _async_execute_cache_only() using _load_cached_entries()

kurodo3[bot]
and
claude
committed
refactor(ENG-379): refactor execute() with selective DB reload and concurrent path

kurodo3[bot]
and
claude
committed
refactor(ENG-379): simplify async_execute() Phase 1 using _load_cached_entries()

kurodo3[bot]
and
claude
committed
refactor(ENG-379): remove dead methods (iter_sequential/concurrent, iter_all_from_database, load_all_cached_records)

kurodo3[bot]
and
claude
committed
test(ENG-379): update test_function_pod_node_stream.py — add run() before compute-dependent assertions

kurodo3[bot]
and
claude
committed
test(ENG-379): update remaining test files for read-only iter_packets semantics

kurodo3[bot]
and
claude
committed
fix(ENG-379): as_table() returns empty pa.Table when iter_packets() yields nothing

kurodo3[bot]
and
claude
committed
test(ENG-379): fix test_function_node_sequential_uses_execute_packet for read-only iter_packets
kurodo3[bot]
committed
fix(ENG-379): fix execute() on_packet_start ordering and test regressions

kurodo3[bot]
and
claude
committed
test(ENG-379): fix test_caches_computed_results in test-objective — add run() before iter_packets()

kurodo3[bot]
and
claude
committed
fix(ENG-379): address Copilot review — None guard, run() READ_ONLY, get_cached_results filter

kurodo3[bot]
and
claude
committed
fix(ENG-379): address second Copilot review — cache-hit check, doc correctness

kurodo3[bot]
and
claude
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(ENG-379): make iter_packets() read-only, consolidate DB join sites#131

refactor(ENG-379): make iter_packets() read-only, consolidate DB join sites#131
eywalker merged 26 commits intodevfrom
eywalker/eng-379-refactor-functionnode-clean-up-redundant-logic-and-ensure

Commits on Apr 7, 2026

docs: add FunctionNode refactor design spec (ENG-379)

docs(ENG-379): add implementation plan for FunctionNode refactor

test(ENG-379): add failing tests for read-only iter_packets semantics

test(ENG-379): fix unused asyncio import and misleading concurrent docstring

test(ENG-379): remove stale asyncio.gather mention from module docstring

feat(ENG-379): add _load_cached_entries() single DB join helper

refactor(ENG-379): extract entry_ids_col before join.drop() for clarity

refactor(ENG-379): store _cached_output_packets by entry_id, remove cache_index

refactor(ENG-379): update _cached_output_packets type annotation to str | int for intermediate state

refactor(ENG-379): rewrite run() with load_status guard delegating to execute()

refactor(ENG-379): rewrite iter_packets() as strictly read-only with DB hot-load

refactor(ENG-379): remove _cached_input_iterator/_needs_iterator iterator state

refactor(ENG-379): revert str annotation to str|int interim, remove dead iterator writes in get_cached_results

refactor(ENG-379): simplify get_cached_results() using _load_cached_entries(), add-only semantics

refactor(ENG-379): simplify _async_execute_cache_only() using _load_cached_entries()

refactor(ENG-379): refactor execute() with selective DB reload and concurrent path

refactor(ENG-379): simplify async_execute() Phase 1 using _load_cached_entries()

refactor(ENG-379): remove dead methods (iter_sequential/concurrent, iter_all_from_database, load_all_cached_records)

test(ENG-379): update test_function_pod_node_stream.py — add run() before compute-dependent assertions

test(ENG-379): update remaining test files for read-only iter_packets semantics

fix(ENG-379): as_table() returns empty pa.Table when iter_packets() yields nothing

test(ENG-379): fix test_function_node_sequential_uses_execute_packet for read-only iter_packets

fix(ENG-379): fix execute() on_packet_start ordering and test regressions

test(ENG-379): fix test_caches_computed_results in test-objective — add run() before iter_packets()

fix(ENG-379): address Copilot review — None guard, run() READ_ONLY, get_cached_results filter

fix(ENG-379): address second Copilot review — cache-hit check, doc correctness