feat(report): non-zero exit on validation failure + document the report#75
Merged
Conversation
Finishes the validation-report story (follows #74). - index: the CLI now exits non-zero when overallPass is false, so CI steps and shell `&&` chains catch a failed run. New --exit-zero flag opts out (e.g. when you only want the report). parseArgs is exported and unit-tested. - README: new "Validation report" section documenting validation-report.html + report.json, the out/<slug>/ layout, the CI exit-code behavior, and the --no-report / --report-format / --report-embed / --report-open / --exit-zero flags. Tests: parseArgs flag parsing (incl. --exit-zero, invalid format ignored, defaults). 49/49 pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
dadachi
added a commit
that referenced
this pull request
May 22, 2026
…kflow (#76) Adds section 10 to docs/validation-report.md covering how to render and visually verify validation-report.html: - Path A — Playwright MCP (interactive, inside Claude Code): local-scope `claude mcp add playwright`, restart to load tools, then browser_navigate (file:// URL) + browser_take_screenshot. Note it's a maintainer convenience, not part of the pipeline (device shots use mobile-mcp). - Path B — Playwright CLI (headless, no MCP, CI-friendly): `npx -y playwright@latest screenshot --full-page file://… report.png`, no project dependency added. Also marks section 9 as shipped (#73/#74/#75). Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Finishes the validation-report story (follows #74) by making the report usable in CI and discoverable.
CI exit code
The CLI now exits non-zero when validation fails (
overallPass === false), so CI steps and shell&&chains catch a failed run:New
--exit-zeroflag opts out (e.g. when you only want the report regardless of pass/fail).parseArgsis now exported and unit-tested.Docs
New Validation report section in the README documenting:
validation-report.html(self-contained) +report.json(machine-readable)out/<slug>/layout (updated thetreeexample)--no-report,--report-format,--report-embed,--report-open,--exit-zeroTests
parseArgsflag parsing — including--exit-zero, invalid--report-formatignored, and bare-spec defaults.npm run cigreen — 49/49 pass.🤖 Generated with Claude Code