Drop onboarding reload ceremony#54
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror of upstream nativeapptemplate/NativeAppTemplate-iOS#64.
Summary
reload()fromOnboardingRepositoryProtocoland all impls. Onboarding slides are static client-side data, so the reload-then-read indirection through repository → viewModel → view.task was just ceremony.OnboardingViewModel.onboardingsas a computed pass-through to the repository..task { viewModel.reload() }fromOnboardingView.reloadCalledinstrumentation fromTestOnboardingRepositoryand update the corresponding tests.Net diff: 8 files, +8/-104.
Test plan
make lintpassesxcodebuild ... build-for-testingsucceeds (iPhone 17, iOS 26.4.1)🤖 Generated with Claude Code