Fix Add-ItemTag FAB accessibility label#58
Merged
Conversation
The Add-ItemTag FAB in ItemTagListView used R.string.add_shop ("Add
Shop") as its contentDescription, so screen readers announced the wrong
action. Use the existing R.string.label_add_item_tag ("Add Item Tag").
The Shops list FAB keeps add_shop, which is correct there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The floating action button in
ItemTagListViewwhoseonClickisonAddItemTagClick(...)usedR.string.add_shop("Add Shop") as itscontentDescription, so screen readers announced the wrong action. The visible title/form already say "Add Item Tag"; only the accessibility label was wrong (surfaced in the element tree, not visually). Swapped to the existingR.string.label_add_item_tag("Add Item Tag").The Shops list FAB (
ShopListView) keepsadd_shop— correct there, since it adds a shop.Cosmetic/a11y only; no behavior change. Companion to the paid edition's PR in NativeAppTemplate-Android.
🤖 Generated with Claude Code