Skip to content

Conversation

@5ZYSZ3K
Copy link
Collaborator

@5ZYSZ3K 5ZYSZ3K commented Oct 17, 2025

This is a follow up to: #13, just made with a source branch from this repo, to b able to preview targeting PRs in one place

Description

This PR is meant to move the contents of react-native-render-html to this library with no other changes

Ultimately I decided to move packages/render-html and apps directories to the repo

  • packages/render-html contains the core logic of react-native-render-html
  • apps contains testing applications that may be helpful

I plan to create pull requests based off of this one to actually get it to work

References

Repository merge with history guide: https://gfscott.com/blog/merge-git-repos-and-keep-commit-history/
react-native-render-html repo: https://github.com/meliorence/react-native-render-html

Repository merge with history guide: https://gfscott.com/blog/merge-git-repos-and-keep-commit-history/
react-native-render-html repo: https://github.com/meliorence/react-native-render-html

@jsamr jsamr marked this pull request as draft November 26, 2025 14:22
@jsamr
Copy link
Contributor

jsamr commented Nov 26, 2025

@5ZYSZ3K I converted to draft to make it clear this is a WIP. Please re-request for review when it's ready to be merged.

@jsamr jsamr mentioned this pull request Dec 12, 2025
@5ZYSZ3K 5ZYSZ3K marked this pull request as ready for review December 15, 2025 21:47
@5ZYSZ3K
Copy link
Collaborator Author

5ZYSZ3K commented Dec 15, 2025

@jsamr there are still issues with bundling the website, but we decided to drop it for now. I think that I would try to release it in early alpha before christmas, so that we would have it prepared for a full major release which would take place in a new year

@jsamr
Copy link
Contributor

jsamr commented Dec 16, 2025

@5ZYSZ3K That sounds absolutely reasonable 🙏🏻

@5ZYSZ3K
Copy link
Collaborator Author

5ZYSZ3K commented Dec 18, 2025

@jsamr do you think you will be able to review it by monday?
And if not, would you mind if I tried make an alpha release from a branch?

And whatever the case: Is it okay if I would go ahead and create the package in npm, or do you want to do it yourself?

@jsamr jsamr self-requested a review December 18, 2025 21:28
@5ZYSZ3K 5ZYSZ3K force-pushed the chore/migrate-render-html-with-history branch from 59dc49a to d7130d2 Compare December 23, 2025 13:14
@5ZYSZ3K
Copy link
Collaborator Author

5ZYSZ3K commented Dec 23, 2025

@jsamr I noticed only now, as I tried to get that merged to release the alpha version from main, that this github repository requires commits to be signed. Unfortunatelly I noticed that quite a few of them are not signed - I think that all of merge commits + some of those created by software mansion people.
What would you like to do about it? I think that I will be able to sign all of those commits by myself, but an easier approach would be to disable that rule. Do you have a preference or other ideas?

And we also realized that we should release render, transient-render-engine and css-processor together - is it ok to create an alpha release for all three of them?

@5ZYSZ3K
Copy link
Collaborator Author

5ZYSZ3K commented Dec 24, 2025

@jsamr Just to let you know: I've been trying to get the alpha release from the branch, but it seems like our release-it config is no longer valid, it fails to get that released because of workspaces. I'll probably give it another shot after christmas, and I'll probably ask for help from someone who has experience with this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.