Add target editing through API and UI#17
Merged
Conversation
6d45c66 to
2a897d6
Compare
Contributor
Author
|
Resolved the merge conflict by rebasing this branch onto the latest The only conflict was in Verification after rebase:
Force-pushed the rebased branch (history rewrite). |
nathanwhit
added a commit
that referenced
this pull request
Jun 15, 2026
A manager-spawned pr_followup (#17) hit 'store: not found' on update_pr and its fix commit was stranded — three layered root causes, all fixed here. RC1 (id mismatch): update_pr/comment_pr required the internal Orcha pr_id but agents naturally pass the GitHub PR number they see everywhere. Add resolvePR: accept either, resolving a bare number within the caller's objective, and on miss return an error listing the objective's PRs and ids instead of a bare 'not found'. RC2 (no workspace): a follow-up's PR-branch checkout + pr_id were only wired up in the automatic ProcessFeedback path. A manager spawning pr_followup/ci_followup via spawn_session got none of it, so the worker ran in a scratch dir and its commit went to a stranded branch. Extract spawnPRFollowup as the single creation path; add an address_pr_feedback manager tool; remove the follow-up roles from spawn_session and reject them there so the wiring can't be bypassed. RC3 (silent wrong push): UpdatePR fell back to the orchestrator's own cwd when no workspace resolved, pushing the wrong branch (or nothing) silently. Resolve the checkout from the PR's own branch workspace and refuse to push when none exists. Updates manager steering/guidance to point at address_pr_feedback. Adds tests covering id resolution, the spawn_session guard, address_pr_feedback wiring, and the no-checkout refusal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/api/targets/{id}Verification
git diff --checkclean